All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Denys Vlasenko <vda.linux@googlemail.com>,
	Shuah Khan <shuah.kh@samsung.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86, selftests: Add sigreturn_32 selftest
Date: Mon, 9 Mar 2015 17:29:08 +0100	[thread overview]
Message-ID: <20150309162908.GA22895@gmail.com> (raw)
In-Reply-To: <0ab957716f8bfca562bac3134f2aabe8156cf0c0.1425917146.git.luto@amacapital.net>


* Andy Lutomirski <luto@amacapital.net> wrote:

> This is my sigreturn test, added mostly unchanged from its old home.
> 
> The integration with the selftest build process seems okay if not
> particularly elegant.
> 
> I'm not using the ksft_ helpers at all yet.  I can do that later.

Cool!

Doesn't seem to build on Ubuntu though:

make[1]: Entering directory 
'/home/mingo/tip/tools/testing/selftests/x86'
gcc -m32 -o sigreturn_32 -O2 -g -std=gnu99 -pthread -Wall  sigreturn.c -lrt -ldl
sigreturn.c:13:22: fatal error: sys/time.h: No such file or directory
 #include <sys/time.h>
                      ^
compilation terminated.
Makefile:18: recipe for target 'sigreturn_32' failed

also, run_tests.sh probably wants to be executable?

Thanks,

	Ingo

  parent reply	other threads:[~2015-03-09 16:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 16:08 [PATCH] x86, selftests: Add sigreturn_32 selftest Andy Lutomirski
2015-03-09 16:26 ` Shuah Khan
2015-03-09 16:29 ` Ingo Molnar [this message]
2015-03-09 16:36   ` Andy Lutomirski
2015-03-09 16:45     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150309162908.GA22895@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=rostedt@goodmis.org \
    --cc=shuah.kh@samsung.com \
    --cc=vda.linux@googlemail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.