From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751596AbbCIQpc (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Mar 2015 12:45:32 -0400
Received: from mail-we0-f182.google.com ([74.125.82.182]:34642 "EHLO
	mail-we0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751012AbbCIQpa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Mar 2015 12:45:30 -0400
Date: Mon, 9 Mar 2015 17:45:23 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Denys Vlasenko <vda.linux@googlemail.com>,
        Shuah Khan <shuah.kh@samsung.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86, selftests: Add sigreturn_32 selftest
Message-ID: <20150309164522.GB24910@gmail.com>
References: <0ab957716f8bfca562bac3134f2aabe8156cf0c0.1425917146.git.luto@amacapital.net>
 <20150309162908.GA22895@gmail.com>
 <CALCETrWf-9ohU1VM96V05Wd3x5ALXa9e+18XgrdUEE5tUKw4mQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrWf-9ohU1VM96V05Wd3x5ALXa9e+18XgrdUEE5tUKw4mQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Andy Lutomirski <luto@amacapital.net> wrote:

> On Mon, Mar 9, 2015 at 9:29 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Andy Lutomirski <luto@amacapital.net> wrote:
> >
> >> This is my sigreturn test, added mostly unchanged from its old home.
> >>
> >> The integration with the selftest build process seems okay if not
> >> particularly elegant.
> >>
> >> I'm not using the ksft_ helpers at all yet.  I can do that later.
> >
> > Cool!
> >
> > Doesn't seem to build on Ubuntu though:
> >
> > make[1]: Entering directory
> > '/home/mingo/tip/tools/testing/selftests/x86'
> > gcc -m32 -o sigreturn_32 -O2 -g -std=gnu99 -pthread -Wall  sigreturn.c -lrt -ldl
> > sigreturn.c:13:22: fatal error: sys/time.h: No such file or directory
> >  #include <sys/time.h>
> >                       ^
> > compilation terminated.
> > Makefile:18: recipe for target 'sigreturn_32' failed
> >
> > also, run_tests.sh probably wants to be executable?
> 
> I think it is:
> 
> diff --git a/tools/testing/selftests/x86/run_tests.sh
> b/tools/testing/selftests/x86/run_tests.sh
> new file mode 100755

Indeed, I'm using broken tools ...

Thanks,

	Ingo