[Qemu-devel] [PATCH 0/3] ppc64-softmmu: default config cleanups

[Qemu-devel] [PATCH 0/3] ppc64-softmmu: default config cleanups

[Alexey Kardashevskiy]

Originally I just wanted to remove FDC but as we are here, let's do some more
cleaning.

Please comment. Thanks.


Alexey Kardashevskiy (3):
  Revert "default-configs/ppc64: add all components of i82378 SuperIO
    chip used by prep"
  ppc64-softmmu: Remove unsupported FDC from config
  ppc64-softmmu: Remove duplicated OPENPIC from config

 default-configs/ppc64-softmmu.mak | 8 --------
 1 file changed, 8 deletions(-)

-- 
2.0.0

[Qemu-devel] [PATCH 1/3] Revert "default-configs/ppc64: add all components of i82378 SuperIO chip used by prep"

[Alexey Kardashevskiy]

This reverts commit 9c9984242ce46ccf8636f5c19e81d794e84aa0c7 as even when
it was applied, all supposedly new config options were already enabled.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 default-configs/ppc64-softmmu.mak | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak
index f195a87..2d97bdf 100644
--- a/default-configs/ppc64-softmmu.mak
+++ b/default-configs/ppc64-softmmu.mak
@@ -50,11 +50,5 @@ CONFIG_LIBDECNUMBER=y
 CONFIG_XICS=$(CONFIG_PSERIES)
 CONFIG_XICS_KVM=$(and $(CONFIG_PSERIES),$(CONFIG_KVM))
 # For PReP
-CONFIG_I82378=y
-CONFIG_I8259=y
-CONFIG_I8254=y
-CONFIG_PCSPK=y
-CONFIG_I82374=y
-CONFIG_I8257=y
 CONFIG_MC146818RTC=y
 CONFIG_ISA_TESTDEV=y
-- 
2.0.0

Re: [Qemu-devel] [PATCH 1/3] Revert "default-configs/ppc64: add all components of i82378 SuperIO chip used by prep"

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Mon, Mar 02, 2015 at 05:46:25PM +1100, Alexey Kardashevskiy wrote:
> This reverts commit 9c9984242ce46ccf8636f5c19e81d794e84aa0c7 as even when
> it was applied, all supposedly new config options were already enabled.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

[Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[Alexey Kardashevskiy]

This removes floppy disks support as it is not supported by any PPC64
system anyway as the only way to have floppy disk on such systems would
be an ISA bus and Linux kernels seems have never had such support.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---

At the moment on POWERPC platform ISA bus depends on CHRP config option
which is so unsupported that it depends on 6xx config option which is not
defined anywhere in the kernel (there is PPC_6xx instead with PPC_ prefix).
---
 default-configs/ppc64-softmmu.mak | 1 -
 1 file changed, 1 deletion(-)

diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak
index 2d97bdf..53f5c73 100644
--- a/default-configs/ppc64-softmmu.mak
+++ b/default-configs/ppc64-softmmu.mak
@@ -10,7 +10,6 @@ CONFIG_SERIAL=y
 CONFIG_PARALLEL=y
 CONFIG_I8254=y
 CONFIG_PCKBD=y
-CONFIG_FDC=y
 CONFIG_I8257=y
 CONFIG_I82374=y
 CONFIG_OPENPIC=y
-- 
2.0.0

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

On Mon, Mar 02, 2015 at 05:46:26PM +1100, Alexey Kardashevskiy wrote:
> This removes floppy disks support as it is not supported by any PPC64
> system anyway as the only way to have floppy disk on such systems would
> be an ISA bus and Linux kernels seems have never had such support.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[Alexander Graf]

On 02.03.15 00:46, Alexey Kardashevskiy wrote:
> This removes floppy disks support as it is not supported by any PPC64
> system anyway as the only way to have floppy disk on such systems would
> be an ISA bus and Linux kernels seems have never had such support.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

I removed this patch from my queue again. The ppc64-softmmu target can
execute -M PReP which in turn uses the fdc.


Alex

> ---
> 
> At the moment on POWERPC platform ISA bus depends on CHRP config option
> which is so unsupported that it depends on 6xx config option which is not
> defined anywhere in the kernel (there is PPC_6xx instead with PPC_ prefix).
> ---
>  default-configs/ppc64-softmmu.mak | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak
> index 2d97bdf..53f5c73 100644
> --- a/default-configs/ppc64-softmmu.mak
> +++ b/default-configs/ppc64-softmmu.mak
> @@ -10,7 +10,6 @@ CONFIG_SERIAL=y
>  CONFIG_PARALLEL=y
>  CONFIG_I8254=y
>  CONFIG_PCKBD=y
> -CONFIG_FDC=y
>  CONFIG_I8257=y
>  CONFIG_I82374=y
>  CONFIG_OPENPIC=y
> 

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[Alexey Kardashevskiy]

On 03/09/2015 11:31 PM, Alexander Graf wrote:
>
>
> On 02.03.15 00:46, Alexey Kardashevskiy wrote:
>> This removes floppy disks support as it is not supported by any PPC64
>> system anyway as the only way to have floppy disk on such systems would
>> be an ISA bus and Linux kernels seems have never had such support.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>
> I removed this patch from my queue again. The ppc64-softmmu target can
> execute -M PReP which in turn uses the fdc.


Out of curiosity - do you have actual 64bit guests being able to run on 
PReP? :) Current Linux ditched its support...


>
>
> Alex
>
>> ---
>>
>> At the moment on POWERPC platform ISA bus depends on CHRP config option
>> which is so unsupported that it depends on 6xx config option which is not
>> defined anywhere in the kernel (there is PPC_6xx instead with PPC_ prefix).
>> ---
>>   default-configs/ppc64-softmmu.mak | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak
>> index 2d97bdf..53f5c73 100644
>> --- a/default-configs/ppc64-softmmu.mak
>> +++ b/default-configs/ppc64-softmmu.mak
>> @@ -10,7 +10,6 @@ CONFIG_SERIAL=y
>>   CONFIG_PARALLEL=y
>>   CONFIG_I8254=y
>>   CONFIG_PCKBD=y
>> -CONFIG_FDC=y
>>   CONFIG_I8257=y
>>   CONFIG_I82374=y
>>   CONFIG_OPENPIC=y
>>


-- 
Alexey

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[Alexey Kardashevskiy]

On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote:
> On 03/09/2015 11:31 PM, Alexander Graf wrote:
>>
>>
>> On 02.03.15 00:46, Alexey Kardashevskiy wrote:
>>> This removes floppy disks support as it is not supported by any PPC64
>>> system anyway as the only way to have floppy disk on such systems would
>>> be an ISA bus and Linux kernels seems have never had such support.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>
>> I removed this patch from my queue again. The ppc64-softmmu target can
>> execute -M PReP which in turn uses the fdc.
>
>
> Out of curiosity - do you have actual 64bit guests being able to run on
> PReP? :) Current Linux ditched its support...


Paul suggested that there has never ever been a 64bit PReP CPU so there is 
no point in emulating it in QEMU. Or there is some reason for that?



-- 
Alexey

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]

On Tue, Mar 10, 2015 at 02:52:48PM +1100, Alexey Kardashevskiy wrote:
> On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote:
> >On 03/09/2015 11:31 PM, Alexander Graf wrote:
> >>
> >>
> >>On 02.03.15 00:46, Alexey Kardashevskiy wrote:
> >>>This removes floppy disks support as it is not supported by any PPC64
> >>>system anyway as the only way to have floppy disk on such systems would
> >>>be an ISA bus and Linux kernels seems have never had such support.
> >>>
> >>>Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> >>
> >>I removed this patch from my queue again. The ppc64-softmmu target can
> >>execute -M PReP which in turn uses the fdc.
> >
> >
> >Out of curiosity - do you have actual 64bit guests being able to run on
> >PReP? :) Current Linux ditched its support...
> 
> 
> Paul suggested that there has never ever been a 64bit PReP CPU so there is
> no point in emulating it in QEMU. Or there is some reason for that?

IIUC, qemu-system-ppc64 (roughly speaking) emulates a superset of what
qemu-system-ppc does, not a different set of hardware.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[Alexey Kardashevskiy]

On 03/10/2015 02:58 PM, David Gibson wrote:
> On Tue, Mar 10, 2015 at 02:52:48PM +1100, Alexey Kardashevskiy wrote:
>> On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote:
>>> On 03/09/2015 11:31 PM, Alexander Graf wrote:
>>>>
>>>>
>>>> On 02.03.15 00:46, Alexey Kardashevskiy wrote:
>>>>> This removes floppy disks support as it is not supported by any PPC64
>>>>> system anyway as the only way to have floppy disk on such systems would
>>>>> be an ISA bus and Linux kernels seems have never had such support.
>>>>>
>>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>>>
>>>> I removed this patch from my queue again. The ppc64-softmmu target can
>>>> execute -M PReP which in turn uses the fdc.
>>>
>>>
>>> Out of curiosity - do you have actual 64bit guests being able to run on
>>> PReP? :) Current Linux ditched its support...
>>
>>
>> Paul suggested that there has never ever been a 64bit PReP CPU so there is
>> no point in emulating it in QEMU. Or there is some reason for that?
>
> IIUC, qemu-system-ppc64 (roughly speaking) emulates a superset of what
> qemu-system-ppc does, not a different set of hardware.

Well, default-configs/ppc-softmmu.mak does not include 
default-configs/ppc64-softmmu.mak or vice versa so I would say these are 
pretty independent and I would simply remove CONFIG_PREP* from 
default-configs/ppc64-softmmu.mak.


-- 
Alexey

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[Alexander Graf]

> Am 09.03.2015 um 23:44 schrieb Alexey Kardashevskiy <aik@ozlabs.ru>:
> 
>> On 03/10/2015 02:58 PM, David Gibson wrote:
>>> On Tue, Mar 10, 2015 at 02:52:48PM +1100, Alexey Kardashevskiy wrote:
>>>> On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote:
>>>>> On 03/09/2015 11:31 PM, Alexander Graf wrote:
>>>>> 
>>>>> 
>>>>>> On 02.03.15 00:46, Alexey Kardashevskiy wrote:
>>>>>> This removes floppy disks support as it is not supported by any PPC64
>>>>>> system anyway as the only way to have floppy disk on such systems would
>>>>>> be an ISA bus and Linux kernels seems have never had such support.
>>>>>> 
>>>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>>>> 
>>>>> I removed this patch from my queue again. The ppc64-softmmu target can
>>>>> execute -M PReP which in turn uses the fdc.
>>>> 
>>>> 
>>>> Out of curiosity - do you have actual 64bit guests being able to run on
>>>> PReP? :) Current Linux ditched its support...
>>> 
>>> 
>>> Paul suggested that there has never ever been a 64bit PReP CPU so there is
>>> no point in emulating it in QEMU. Or there is some reason for that?
>> 
>> IIUC, qemu-system-ppc64 (roughly speaking) emulates a superset of what
>> qemu-system-ppc does, not a different set of hardware.
> 
> Well, default-configs/ppc-softmmu.mak does not include default-configs/ppc64-softmmu.mak or vice versa so I would say these are pretty independent and I would simply remove CONFIG_PREP* from default-configs/ppc64-softmmu.mak.

Convention so far has been that ppc64 includes ppc includes ppcemb. I don't see why we should break that assumption.

However I do agree that we should probably reflect it with includes in the mak files.


Alex

> 
> 
> -- 
> Alexey

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[Alexey Kardashevskiy]

On 03/10/2015 04:38 PM, Alexander Graf wrote:
>
>
>
>> Am 09.03.2015 um 23:44 schrieb Alexey Kardashevskiy <aik@ozlabs.ru>:
>>
>>> On 03/10/2015 02:58 PM, David Gibson wrote:
>>>> On Tue, Mar 10, 2015 at 02:52:48PM +1100, Alexey Kardashevskiy wrote:
>>>>> On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote:
>>>>>> On 03/09/2015 11:31 PM, Alexander Graf wrote:
>>>>>>
>>>>>>
>>>>>>> On 02.03.15 00:46, Alexey Kardashevskiy wrote:
>>>>>>> This removes floppy disks support as it is not supported by any PPC64
>>>>>>> system anyway as the only way to have floppy disk on such systems would
>>>>>>> be an ISA bus and Linux kernels seems have never had such support.
>>>>>>>
>>>>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>>>>>
>>>>>> I removed this patch from my queue again. The ppc64-softmmu target can
>>>>>> execute -M PReP which in turn uses the fdc.
>>>>>
>>>>>
>>>>> Out of curiosity - do you have actual 64bit guests being able to run on
>>>>> PReP? :) Current Linux ditched its support...
>>>>
>>>>
>>>> Paul suggested that there has never ever been a 64bit PReP CPU so there is
>>>> no point in emulating it in QEMU. Or there is some reason for that?
>>>
>>> IIUC, qemu-system-ppc64 (roughly speaking) emulates a superset of what
>>> qemu-system-ppc does, not a different set of hardware.
>>
>> Well, default-configs/ppc-softmmu.mak does not include default-configs/ppc64-softmmu.mak or vice versa so I would say these are pretty independent and I would simply remove CONFIG_PREP* from default-configs/ppc64-softmmu.mak.
>
> Convention so far has been that ppc64 includes ppc includes ppcemb. I don't see why we should break that assumption.



[aik@vpl2 ~]$ ./qemu-system-ppc64 -device help 2>&1 | grep fdc
name "isa-fdc", bus ISA
name "sysbus-fdc", bus System


afaik there is no way to get "fdc" working with qemu-system-ppc64 but 
"-device help" suggests there is a way and libvirt thinks (the original 
request came from there) it can add floppy disk. If later we use "-fda" 
with QEMU, it will warn about "Orphaned drive" as there is no fdc device. 
Ok, I can be sneakier and add "-device i82378" but I wonder if there is a 
PPC64 guest with FDC driver enabled. When I try to enable it in the current 
upstream (or anything since 2010), it needs ISA which depends on CHRP 
(about to be ditched, and PReP is ditched already) which depends on 6xx 
which is not defined at all (PPC_6xx is but not 6xx).

So if you know how to get working floppy disk with qemu-system-ppc64, that 
would help me a lot in rejecting requests from libvirt folks :) Thanks :)



> However I do agree that we should probably reflect it with includes in the mak files.
>
>
> Alex
>
>>
>>
>> --
>> Alexey


-- 
Alexey

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[Alexander Graf]

On 10.03.15 04:20, Alexey Kardashevskiy wrote:
> On 03/10/2015 04:38 PM, Alexander Graf wrote:
>>
>>
>>
>>> Am 09.03.2015 um 23:44 schrieb Alexey Kardashevskiy <aik@ozlabs.ru>:
>>>
>>>> On 03/10/2015 02:58 PM, David Gibson wrote:
>>>>> On Tue, Mar 10, 2015 at 02:52:48PM +1100, Alexey Kardashevskiy wrote:
>>>>>> On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote:
>>>>>>> On 03/09/2015 11:31 PM, Alexander Graf wrote:
>>>>>>>
>>>>>>>
>>>>>>>> On 02.03.15 00:46, Alexey Kardashevskiy wrote:
>>>>>>>> This removes floppy disks support as it is not supported by any
>>>>>>>> PPC64
>>>>>>>> system anyway as the only way to have floppy disk on such
>>>>>>>> systems would
>>>>>>>> be an ISA bus and Linux kernels seems have never had such support.
>>>>>>>>
>>>>>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>>>>>>
>>>>>>> I removed this patch from my queue again. The ppc64-softmmu
>>>>>>> target can
>>>>>>> execute -M PReP which in turn uses the fdc.
>>>>>>
>>>>>>
>>>>>> Out of curiosity - do you have actual 64bit guests being able to
>>>>>> run on
>>>>>> PReP? :) Current Linux ditched its support...
>>>>>
>>>>>
>>>>> Paul suggested that there has never ever been a 64bit PReP CPU so
>>>>> there is
>>>>> no point in emulating it in QEMU. Or there is some reason for that?
>>>>
>>>> IIUC, qemu-system-ppc64 (roughly speaking) emulates a superset of what
>>>> qemu-system-ppc does, not a different set of hardware.
>>>
>>> Well, default-configs/ppc-softmmu.mak does not include
>>> default-configs/ppc64-softmmu.mak or vice versa so I would say these
>>> are pretty independent and I would simply remove CONFIG_PREP* from
>>> default-configs/ppc64-softmmu.mak.
>>
>> Convention so far has been that ppc64 includes ppc includes ppcemb. I
>> don't see why we should break that assumption.
> 
> 
> 
> [aik@vpl2 ~]$ ./qemu-system-ppc64 -device help 2>&1 | grep fdc
> name "isa-fdc", bus ISA
> name "sysbus-fdc", bus System
> 
> 
> afaik there is no way to get "fdc" working with qemu-system-ppc64 but

It might work with -M prep, but definitely not any of the others. The
same holds true for qemu-system-ppc. There also only -M prep supports an
ISA bus, all the other machines don't.

> "-device help" suggests there is a way and libvirt thinks (the original
> request came from there) it can add floppy disk. If later we use "-fda"
> with QEMU, it will warn about "Orphaned drive" as there is no fdc
> device. Ok, I can be sneakier and add "-device i82378" but I wonder if
> there is a PPC64 guest with FDC driver enabled. When I try to enable it
> in the current upstream (or anything since 2010), it needs ISA which
> depends on CHRP (about to be ditched, and PReP is ditched already) which
> depends on 6xx which is not defined at all (PPC_6xx is but not 6xx).

The fact that we have an fdc in the "device bucket" doesn't mean that
that particular device can ever be instantiated. We don't have an ISA
bus, so we can't really ;).

> So if you know how to get working floppy disk with qemu-system-ppc64,
> that would help me a lot in rejecting requests from libvirt folks :)
> Thanks :)

I don't think you want floppy disk emulation on -M pseries at all. In
fact, you only ever want floppy disk emulation on x86. So I'd recommend
to change the logic in libvirt accordingly and just hard code floppy
emulation to x86 (and if alpha or some other weird architecture needs it
later as well, have them extend the list).


Alex

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[Maciej W. Rozycki]

On Wed, 11 Mar 2015, Alexander Graf wrote:

> > So if you know how to get working floppy disk with qemu-system-ppc64,
> > that would help me a lot in rejecting requests from libvirt folks :)
> > Thanks :)
> 
> I don't think you want floppy disk emulation on -M pseries at all. In
> fact, you only ever want floppy disk emulation on x86. So I'd recommend
> to change the logic in libvirt accordingly and just hard code floppy
> emulation to x86 (and if alpha or some other weird architecture needs it
> later as well, have them extend the list).

 For the record: the MIPS Malta board that we support also has direct PC 
FDD support.  The real board has a SMSC FDC37M817 super I/O controller 
chip wired to Intel 82371EB (PIIX4E) south bridge's LPC interface and a 
suitable IDC header for a FDD data cable soldered onto the PCB as well.  
So it's not only x86 that can make use of floppy disk emulation.  Note 
that there's no real ISA (no slots) on the Malta board, only the LPC and 
PIIX4E on-chip stuff.

  Maciej

[Qemu-devel] [PATCH 3/3] ppc64-softmmu: Remove duplicated OPENPIC from config

[Alexey Kardashevskiy]

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 default-configs/ppc64-softmmu.mak | 1 -
 1 file changed, 1 deletion(-)

diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak
index 53f5c73..90bdcd1 100644
--- a/default-configs/ppc64-softmmu.mak
+++ b/default-configs/ppc64-softmmu.mak
@@ -37,7 +37,6 @@ CONFIG_PTIMER=y
 CONFIG_I8259=y
 CONFIG_XILINX=y
 CONFIG_XILINX_ETHLITE=y
-CONFIG_OPENPIC=y
 CONFIG_PSERIES=y
 CONFIG_PREP=y
 CONFIG_MAC=y
-- 
2.0.0

Re: [Qemu-devel] [PATCH 3/3] ppc64-softmmu: Remove duplicated OPENPIC from config

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

On Mon, Mar 02, 2015 at 05:46:27PM +1100, Alexey Kardashevskiy wrote:
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [PATCH 0/3] ppc64-softmmu: default config cleanups

[Alexander Graf]

On 02.03.15 07:46, Alexey Kardashevskiy wrote:
> Originally I just wanted to remove FDC but as we are here, let's do some more
> cleaning.
> 
> Please comment. Thanks.

Thanks, applied all to ppc-next and also put the patch below on top.


Alex

commit 8c72f737d383f169a3d679979183c513c54e22a3
Author: Alexander Graf <agraf@suse.de>
Date:   Mon Mar 2 14:31:58 2015 +0100

    PPC: Remove duplicate OPENPIC defines in default-configs

    The CONFIG_OPENPIC variable was declared multiple times. We only
need it once.

    Signed-off-by: Alexander Graf <agraf@suse.de>

diff --git a/default-configs/ppc-softmmu.mak
b/default-configs/ppc-softmmu.mak
index aebfab9..02c9ead 100644
--- a/default-configs/ppc-softmmu.mak
+++ b/default-configs/ppc-softmmu.mak
@@ -38,7 +38,6 @@ CONFIG_PTIMER=y
 CONFIG_I8259=y
 CONFIG_XILINX=y
 CONFIG_XILINX_ETHLITE=y
-CONFIG_OPENPIC=y
 CONFIG_PREP=y
 CONFIG_MAC=y
 CONFIG_E500=y
diff --git a/default-configs/ppcemb-softmmu.mak
b/default-configs/ppcemb-softmmu.mak
index a1b3d5f..54acc4d 100644
--- a/default-configs/ppcemb-softmmu.mak
+++ b/default-configs/ppcemb-softmmu.mak
@@ -13,5 +13,4 @@ CONFIG_PTIMER=y
 CONFIG_I8259=y
 CONFIG_XILINX=y
 CONFIG_XILINX_ETHLITE=y
-CONFIG_OPENPIC=y
 CONFIG_LIBDECNUMBER=y