From: Dan Carpenter <dan.carpenter@oracle.com>
To: markh@compro.net
Cc: Matteo Semenzato <mattew8898@gmail.com>,
gregkh@linuxfoundation.org, lidza.louina@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: dgnc: fix bitmask
Date: Tue, 10 Mar 2015 09:51:46 +0300 [thread overview]
Message-ID: <20150310065146.GL10964@mwanda> (raw)
In-Reply-To: <1425932078-16221-1-git-send-email-mattew8898@gmail.com>
On Mon, Mar 09, 2015 at 09:14:38PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>
>
> The bitmask should be used on msignals since the signals variable is not
> used anywhere in the function.
>
You're probably right. I would really like to get Mark's Ack on this
though becuase it's sort of a guess and not tested.
regards,
dan carpenter
> Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_cls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index bedc522..29c6316 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1137,7 +1137,7 @@ static void cls_parse_modem(struct channel_t *ch, unsigned char signals)
> * Scrub off lower bits. They signify delta's, which I don't
> * care about
> */
> - signals &= 0xf0;
> + msignals &= 0xf0;
>
> spin_lock_irqsave(&ch->ch_lock, flags);
> if (msignals & UART_MSR_DCD)
> --
> 2.3.1
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2015-03-10 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 20:14 [PATCH] Staging: dgnc: fix bitmask Matteo Semenzato
2015-03-10 6:51 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310065146.GL10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=mattew8898@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.