From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize
Date: Tue, 10 Mar 2015 10:39:13 +0300 [thread overview]
Message-ID: <20150310073913.GO10964@mwanda> (raw)
In-Reply-To: <1425918578-10223-1-git-send-email-giedrius.statkevicius@gmail.com>
On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote:
> Remove BOARD_FAILED and don't save dgnc_boards which failed to
> initialize.
>
> Assign the result of kzalloc() to brd in dgnc_found_board() and only put
> it in the dgnc_Board[] if it successfully initializes. Also, remove
> BOARD_FAILED enum and all ifs that check for it. Finally, remove one
> final place where state was set to BOARD_FAILED which was even redundant
> before this patch.
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Great! Very thourough. Thanks. :)
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-10 7:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 16:29 [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize Giedrius Statkevičius
2015-03-10 7:39 ` Dan Carpenter [this message]
2015-03-12 10:08 ` Greg KH
2015-03-12 10:20 ` Dan Carpenter
2015-03-12 16:14 ` Giedrius Statkevičius
2015-03-13 20:55 ` Mark Hounschell
2015-03-14 8:44 ` Greg KH
2015-03-15 12:07 ` Mark Hounschell
2015-03-15 16:38 ` Greg KH
2015-03-16 17:18 ` Mark Hounschell
2015-03-13 20:06 ` Giedrius Statkevičius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310073913.GO10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=giedrius.statkevicius@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.