From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751942AbbCJHmR (ORCPT ); Tue, 10 Mar 2015 03:42:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47146 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbbCJHmO (ORCPT ); Tue, 10 Mar 2015 03:42:14 -0400 Date: Tue, 10 Mar 2015 08:42:10 +0100 From: Greg KH To: "K. Y. Srinivasan" Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com Subject: Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl() Message-ID: <20150310074210.GB11349@kroah.com> References: <1425711852-14332-1-git-send-email-kys@microsoft.com> <1425711874-14371-1-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425711874-14371-1-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 06, 2015 at 11:04:28PM -0800, K. Y. Srinivasan wrote: > Export the vmbus_sendpacket_pagebuffer_ctl() interface. Why? Nothing in this patch needs it. Please include this in the patch that needs the symbol, or at least give a hint as to what is going on. As it is, this just looks like a random export for no reason at all :( greg k-h