From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhanghy@sangfor.com.cn>) id 1YV90h-0004JH-RE
	for qemu-devel@nongnu.org; Mon, 09 Mar 2015 21:31:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhanghy@sangfor.com.cn>) id 1YV90e-0007ij-L8
	for qemu-devel@nongnu.org; Mon, 09 Mar 2015 21:31:03 -0400
Received: from smtp.sangfor.com.cn ([58.251.49.30]:36885
	helo=mail.sangfor.com.cn) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhanghy@sangfor.com.cn>) id 1YV90d-0007fm-Vu
	for qemu-devel@nongnu.org; Mon, 09 Mar 2015 21:31:00 -0400
Date: Tue, 10 Mar 2015 09:30:53 +0800
From: "Zhang Haoyu" <zhanghy@sangfor.com.cn>
References: <201503031452510425241@sangfor.com.cn>,
	<54F58618.6050200@redhat.com>,
	<201503091502590266464@sangfor.com.cn>,
	<201503091614373394821@sangfor.com.cn>
Message-ID: <201503100930531293894@sangfor.com.cn>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] introduce bitmap to bdrv_commit to
	trackdirty sector
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, vsementsov <vsementsov@parallels.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, jsnow <jsnow@redhat.com>


On 2015-03-10 08:29:19, Fam Zheng wrote:
> On Mon, 03/09 16:14, Zhang Haoyu wrote:
> > Hi John, Vladimir 
> > We can using active block commit to implement incremental backup without guest disruption,
> > e.g., 
> > origin <= A <= B <= C <= current BDS,
> > a new external snapshot will be produced before every time backup,
> > we can migrate A, B, C, ... to destination, 
> > then commit_active_start() the unneeded snapshot in source or destination end.
> > 
> > So, comparing with above mechanism,
> > what's the advantages of the incremental backup implemented by John and Vladimir?
> 
> We can't migrate A, B, C because they are buried in the backing chain under
> "current BDS". 
I think we can backup the incremental image(e.g., A, B, C) to destination in top mode,
although I haven't read the code in detail, it can work theoretically, I think.

> Even if we do that, there will be severe IO amplification
> compared to the dirty bitmap way.
> 
Yes, block-commit will produce extra IO.
But regarding incremental backup, when guest IO is performed, 
will the corresponding dirty bit be synchronized to qcow2 image simultaneously?
If yes, it will impact on IO throughput in two sides, I think,
1) extro IO  2) randomize the IO,
if no, if source VM is shut-down in non-normal way, like killed by force or by mistake or server poweroff suddenly,
some dirty bits maybe lost, then full copy is needed.

> For the same reason we have drive-backup (write intercept) instead of a
> "snapshot + drive-mirror" analogue.
> 
drive-backup is not incremental backup, full copy is needed in every time backup,
so it dosen't meet our requirements.

Zhang Haoyu
> Fam