From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YVH6u-0008Vb-CV for mharc-qemu-trivial@gnu.org; Tue, 10 Mar 2015 06:10:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVH6o-0008PW-Ve for qemu-trivial@nongnu.org; Tue, 10 Mar 2015 06:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVH6o-0008JT-34 for qemu-trivial@nongnu.org; Tue, 10 Mar 2015 06:09:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVH6g-0008Gm-8I; Tue, 10 Mar 2015 06:09:46 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2AA9dRk000718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 10 Mar 2015 06:09:40 -0400 Received: from noname.str.redhat.com (dhcp-192-197.str.redhat.com [10.33.192.197]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id t2AA9aLD001741; Tue, 10 Mar 2015 06:09:37 -0400 Date: Tue, 10 Mar 2015 11:09:36 +0100 From: Kevin Wolf To: Fam Zheng Message-ID: <20150310100936.GD3770@noname.str.redhat.com> References: <1425971164-9845-1-git-send-email-mjt@msgid.tls.msk.ru> <20150310085016.GC3770@noname.str.redhat.com> <20150310091759.GC14320@ad.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150310091759.GC14320@ad.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org, armbru@redhat.com, Peter Wu , stefanha@redhat.com Subject: Re: [Qemu-trivial] [PATCH] block/dmg: make it modular if using additional library X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2015 10:09:58 -0000 Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben: > On Tue, 03/10 09:50, Kevin Wolf wrote: > > Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: > > > block/dmg can use additional library (libbz2) to read > > > bzip2-compressed files. Make the block driver to be > > > a module if libbz2 support is requested, to avoid extra > > > library dependency by default. > > > > > > Signed-off-by: Michael Tokarev > > > > First of all: I don't think this is suitable for trivial. The actual > > code change might be small, but the change in behaviour is important and > > needs discussion. > > > > > This might be questionable, to make the thing to be either > > > module or built-in depending on build environment, so a > > > better idea may be to make it modular unconditionally. > > > This block device format isn't used often. > > > > Yes, I'm concerned that making it conditional might be a bit surprising. > > I'd like to hear some more opinions before applying this. > > I don't see the advantage over making it an unconditional module - condition > only makes it a bit more complicated. > > > > > Also, should we consider making some more rarely used image formats > > modules even if they don't pull in external dependencies? > > Sounds reasonable to me. Is the intention to reduce binary size? Yes, that and also that it allows compiling out some drivers without having to mess with the Makefiles. You just don't install all of them. Related to that, Peter also mentioned that you (the user, not developer or packager) could simply disable a single driver, for example as a temporary hotfix in the case of security problems in a block driver. That would actually be an argument for making _all_ drivers modules. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVH6j-0008PO-TI for qemu-devel@nongnu.org; Tue, 10 Mar 2015 06:09:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVH6g-0008Ha-OI for qemu-devel@nongnu.org; Tue, 10 Mar 2015 06:09:49 -0400 Date: Tue, 10 Mar 2015 11:09:36 +0100 From: Kevin Wolf Message-ID: <20150310100936.GD3770@noname.str.redhat.com> References: <1425971164-9845-1-git-send-email-mjt@msgid.tls.msk.ru> <20150310085016.GC3770@noname.str.redhat.com> <20150310091759.GC14320@ad.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150310091759.GC14320@ad.nay.redhat.com> Subject: Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org, armbru@redhat.com, Peter Wu , stefanha@redhat.com Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben: > On Tue, 03/10 09:50, Kevin Wolf wrote: > > Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: > > > block/dmg can use additional library (libbz2) to read > > > bzip2-compressed files. Make the block driver to be > > > a module if libbz2 support is requested, to avoid extra > > > library dependency by default. > > > > > > Signed-off-by: Michael Tokarev > > > > First of all: I don't think this is suitable for trivial. The actual > > code change might be small, but the change in behaviour is important and > > needs discussion. > > > > > This might be questionable, to make the thing to be either > > > module or built-in depending on build environment, so a > > > better idea may be to make it modular unconditionally. > > > This block device format isn't used often. > > > > Yes, I'm concerned that making it conditional might be a bit surprising. > > I'd like to hear some more opinions before applying this. > > I don't see the advantage over making it an unconditional module - condition > only makes it a bit more complicated. > > > > > Also, should we consider making some more rarely used image formats > > modules even if they don't pull in external dependencies? > > Sounds reasonable to me. Is the intention to reduce binary size? Yes, that and also that it allows compiling out some drivers without having to mess with the Makefiles. You just don't install all of them. Related to that, Peter also mentioned that you (the user, not developer or packager) could simply disable a single driver, for example as a temporary hotfix in the case of security problems in a block driver. That would actually be an argument for making _all_ drivers modules. Kevin