From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v2] efi/arm64: use UEFI for system reset and poweroff Date: Tue, 10 Mar 2015 14:48:57 +0000 Message-ID: <20150310144857.GE17573@codeblueprint.co.uk> References: <1425653364-12591-1-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1425653364-12591-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-efi@vger.kernel.org On Fri, 06 Mar, at 03:49:24PM, Ard Biesheuvel wrote: > If UEFI Runtime Services are available, they are preferred over direct > PSCI calls or other methods to reset the system. > > For the reset case, we need to hook into machine_restart(), as the > arm_pm_restart function pointer may be overwritten by modules. > > Tested-by: Mark Rutland > Reviewed-by: Mark Rutland > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/kernel/efi.c | 9 +++++++++ > arch/arm64/kernel/process.c | 8 ++++++++ > 2 files changed, 17 insertions(+) Looks good to me. Reviewed-by: Matt Fleming Catalin, are you picking this up? -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: matt@codeblueprint.co.uk (Matt Fleming) Date: Tue, 10 Mar 2015 14:48:57 +0000 Subject: [PATCH v2] efi/arm64: use UEFI for system reset and poweroff In-Reply-To: <1425653364-12591-1-git-send-email-ard.biesheuvel@linaro.org> References: <1425653364-12591-1-git-send-email-ard.biesheuvel@linaro.org> Message-ID: <20150310144857.GE17573@codeblueprint.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 06 Mar, at 03:49:24PM, Ard Biesheuvel wrote: > If UEFI Runtime Services are available, they are preferred over direct > PSCI calls or other methods to reset the system. > > For the reset case, we need to hook into machine_restart(), as the > arm_pm_restart function pointer may be overwritten by modules. > > Tested-by: Mark Rutland > Reviewed-by: Mark Rutland > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/kernel/efi.c | 9 +++++++++ > arch/arm64/kernel/process.c | 8 ++++++++ > 2 files changed, 17 insertions(+) Looks good to me. Reviewed-by: Matt Fleming Catalin, are you picking this up? -- Matt Fleming, Intel Open Source Technology Center