From: Jeff McGee <jeff.mcgee@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
beignet@lists.freedesktop.org
Subject: Re: [Beignet] [Intel-gfx] [PATCH i-g-t 2/2] configure: Bump required libdrm version to 2.4.60
Date: Tue, 10 Mar 2015 09:59:15 -0700 [thread overview]
Message-ID: <20150310165915.GG3263@jeffdesk> (raw)
In-Reply-To: <20150310073730.GA3800@phenom.ffwll.local>
On Tue, Mar 10, 2015 at 08:37:30AM +0100, Daniel Vetter wrote:
> On Mon, Mar 09, 2015 at 04:41:02PM -0700, jeff.mcgee@intel.com wrote:
> > From: Jeff McGee <jeff.mcgee@intel.com>
> >
> > tests/core_getparams needs the new libdrm interfaces for
> > querying subslice and EU counts.
> >
> > For: VIZ-4636
> > Signed-off-by: Jeff McGee <jeff.mcgee@intel.com>
> > ---
> > configure.ac | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 16d6a2e..88a1c3d 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -82,7 +82,7 @@ if test "x$GCC" = "xyes"; then
> > fi
> > AC_SUBST(ASSEMBLER_WARN_CFLAGS)
> >
> > -PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.52 libdrm])
> > +PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.60 libdrm])
>
> Please don't and instead copypaste the new structs/defines with a local_
> prefix like we do it for all the other new igt testcases. Forcing libdrm
> to get updated for igt all the time can get annoying fast.
> -Daniel
>
In this case I'm trying to exercise new API functions in libdrm which
wrap the GETPARAM ioctl. Would you rather me bypass the wrapper to
avoid requiring updated libdrm? I can do that, but it fails to test the
complete path that client would use.
-Jeff
> > PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
> > PKG_CHECK_MODULES(OVERLAY_XVLIB, [xv x11 xext dri2proto >= 2.6], enable_overlay_xvlib=yes, enable_overlay_xvlib=no)
> > PKG_CHECK_MODULES(OVERLAY_XLIB, [cairo-xlib dri2proto >= 2.6], enable_overlay_xlib=yes, enable_overlay_xlib=no)
> > --
> > 2.3.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> Beignet mailing list
> Beignet@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-10 16:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 23:40 [PATCH] tests/core_getparams: Create new test core_getparams jeff.mcgee
2015-03-09 23:19 ` [PATCH i-g-t 1/2] " jeff.mcgee
2015-03-09 23:19 ` [PATCH i-g-t 2/2] configure: Bump required libdrm version to 2.4.60 jeff.mcgee
2015-03-09 23:30 ` jeff.mcgee
2015-03-09 23:41 ` jeff.mcgee
2015-03-10 7:37 ` [Intel-gfx] " Daniel Vetter
2015-03-10 16:59 ` Jeff McGee [this message]
2015-03-10 17:58 ` [Beignet] " Rob Clark
2015-03-10 18:34 ` Jeff McGee
2015-03-10 18:24 ` [Beignet] " Rob Clark
2015-03-10 18:47 ` [Intel-gfx] " Daniel Vetter
2015-03-10 20:06 ` Jeff McGee
2015-03-11 7:21 ` Daniel Vetter
2015-03-12 20:42 ` [Beignet] " Jeff McGee
2015-03-12 20:38 ` [PATCH i-g-t v2] tests/core_getparams: Create new test core_getparams jeff.mcgee
2015-03-13 0:26 ` [PATCH i-g-t v3] " jeff.mcgee
2015-03-13 8:58 ` Daniel Vetter
2015-03-13 9:09 ` [Intel-gfx] " Zhigang Gong
2015-03-13 16:32 ` Daniel Vetter
2015-03-13 16:51 ` [Beignet] [Intel-gfx] " Jeff McGee
2015-03-13 16:59 ` [Beignet] " Daniel Vetter
2015-03-13 17:03 ` [Intel-gfx] " Jeff McGee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310165915.GG3263@jeffdesk \
--to=jeff.mcgee@intel.com \
--cc=beignet@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.