All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sabrina Dubroca <sd@queasysnail.net>
To: Alexander Duyck <alexander.h.duyck@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [net-next PATCH] fib_trie: Correctly handle case of key == 0 in leaf_walk_rcu
Date: Tue, 10 Mar 2015 19:48:39 +0100	[thread overview]
Message-ID: <20150310184839.GC1743@kria> (raw)
In-Reply-To: <20150310182512.1320.1169.stgit@ahduyck-vm-fedora20>

2015-03-10, 11:25:41 -0700, Alexander Duyck wrote:
> In the case of a trie that had no tnodes with a key of 0 the initial
> look-up would fail resulting in an out-of-bounds cindex on the first tnode.
> This resulted in an entire trie being skipped.
> 
> In order resolve this I have updated the cindex logic in the initial
> look-up so that if the key is zero we will always traverse the child zero
> path.
> 
> Fixes: 8be33e95 ("fib_trie: Fib walk rcu should take a tnode and key instead of a trie and a leaf")
> Reported-by: Sabrina Dubroca <sd@queasysnail.net>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
> ---

Tested-by: Sabrina Dubroca <sd@queasysnail.net>

Thanks Alex.

-- 
Sabrina

  reply	other threads:[~2015-03-10 18:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 17:07 ipv4 route dump broken with multiple subnets Sabrina Dubroca
2015-03-10 17:37 ` Alexander Duyck
2015-03-10 18:25 ` [net-next PATCH] fib_trie: Correctly handle case of key == 0 in leaf_walk_rcu Alexander Duyck
2015-03-10 18:48   ` Sabrina Dubroca [this message]
2015-03-10 20:14     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150310184839.GC1743@kria \
    --to=sd@queasysnail.net \
    --cc=alexander.h.duyck@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.