From mboxrd@z Thu Jan 1 00:00:00 1970 From: balbi@ti.com (Felipe Balbi) Date: Tue, 10 Mar 2015 16:23:53 -0500 Subject: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91 In-Reply-To: <20150310212122.GJ9188@piout.net> References: <1425368567-5333-1-git-send-email-alexandre.belloni@free-electrons.com> <20150303092620.63e1861d@bbrezillon> <20150303094138.GC3892@piout.net> <20150310205312.GD18456@saruman.tx.rr.com> <20150310212122.GJ9188@piout.net> Message-ID: <20150310212353.GI25666@saruman.tx.rr.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 10, 2015 at 10:21:22PM +0100, Alexandre Belloni wrote: > On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote : > > On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote: > > > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote : > > > > > config USB_ATMEL_USBA > > > > > tristate "Atmel USBA" > > > > > - depends on AVR32 || ARCH_AT91 > > > > > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91 > > > > > > > > I guess you should add parenthesis to make it clearer ? > > > > > > > > depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91) > > > > > > > > And I wonder why you need that. I though this option was selected by all > > > > at91 platforms ? > > > > > > > > > > That is currently the case but maybe, one day, one of the AT91 platform > > > will not use the same clock driver. > > > > then, maybe, one day, you send this patch. > > Yeah, let's drop it for now but I have the feeling that this will > break (I actually broke it when switching at91 to multiplatform). aha, that changes it. So you already have something which makes this break ? Are you planning on sending that upstream any time soon ? We could very well use that same series to merge this patch. Only when it's needed ;-) cheers -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753476AbbCJVZB (ORCPT ); Tue, 10 Mar 2015 17:25:01 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:33887 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbbCJVY4 (ORCPT ); Tue, 10 Mar 2015 17:24:56 -0400 Date: Tue, 10 Mar 2015 16:23:53 -0500 From: Felipe Balbi To: Alexandre Belloni CC: Felipe Balbi , Boris Brezillon , Greg Kroah-Hartman , , , , Nicolas Ferre Subject: Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91 Message-ID: <20150310212353.GI25666@saruman.tx.rr.com> Reply-To: References: <1425368567-5333-1-git-send-email-alexandre.belloni@free-electrons.com> <20150303092620.63e1861d@bbrezillon> <20150303094138.GC3892@piout.net> <20150310205312.GD18456@saruman.tx.rr.com> <20150310212122.GJ9188@piout.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ev7mvGV+3JQuI2Eo" Content-Disposition: inline In-Reply-To: <20150310212122.GJ9188@piout.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ev7mvGV+3JQuI2Eo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 10, 2015 at 10:21:22PM +0100, Alexandre Belloni wrote: > On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote : > > On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote: > > > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote : > > > > > config USB_ATMEL_USBA > > > > > tristate "Atmel USBA" > > > > > - depends on AVR32 || ARCH_AT91 > > > > > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91 > > > >=20 > > > > I guess you should add parenthesis to make it clearer ? > > > >=20 > > > > depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91) > > > >=20 > > > > And I wonder why you need that. I though this option was selected b= y all > > > > at91 platforms ? > > > >=20 > > >=20 > > > That is currently the case but maybe, one day, one of the AT91 platfo= rm > > > will not use the same clock driver. > >=20 > > then, maybe, one day, you send this patch. >=20 > Yeah, let's drop it for now but I have the feeling that this will > break (I actually broke it when switching at91 to multiplatform). aha, that changes it. So you already have something which makes this break ? Are you planning on sending that upstream any time soon ? We could very well use that same series to merge this patch. Only when it's needed ;-) cheers --=20 balbi --ev7mvGV+3JQuI2Eo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU/2DpAAoJEIaOsuA1yqREiuAP/ia9dKZl0OupHyU+lc5sw2LM P+8CJkvwFlJVsxhh5zLktX3GP4WbC9rBx4tn/f/DpgwihOuw3iBoeqW4/PQXySce +TsW4DjyDBVBO3/doVMsWnbETGP2YTKyDwftzPn1o4FPzbpcFchyAHQQ397UbJ4y USeQYcyGBEGUosZu48syBh2B5vtasQ6APztFMBQNxmnnsA3Yw70jyHo2GVzhtsde f1oU654cgiXR6B4tLsGm8Bw81/zEwy4aUZJVcv4Ct7qeHT2d2aFtxMmHlHTBGiAU K2BKEGqncDiuNjKR9ETM99nwJakE95472Aoe0qX/6swm62O9+YGih/xSCJ03Igi+ SGSrOeUYscxO4qOYyLfChMHUqDzlzoPGwI0NcsBjHkhVMjEYWA60Kp5lq6n7gf3w BsjorstnYgbWC3Q+GeHQpyoLLOzDcUHNP5krd6ekLMrimuyjt7AERpAuUP/K/fI1 thX6z3LFh036ZsqD5gQ/agdOc+Fu8Js0P9ZgWIE4FLrYLL7Jp2HJjeI+6FFhFeSM zZRrLaLqr9y3qe8QaJZIJKMF6faEFclY6QRDX/Ht880E3CTFUebidony3MyGS6T8 F/gKAn2x9ceIwR1ltIrAynOIR3LW6PedwSfilnmU5BCUjfWXX0AVM/+3LMq/Ns1a Opi+G8n7dTzzeslKiR8a =FOyK -----END PGP SIGNATURE----- --ev7mvGV+3JQuI2Eo--