From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: fib_trie: Add tnode struct as a container for fields not needed in key_vector
Date: Tue, 10 Mar 2015 21:24:34 +0000 [thread overview]
Message-ID: <20150310212434.GD16501@mwanda> (raw)
In-Reply-To: <20150310210425.GA10841@mwanda>
On Tue, Mar 10, 2015 at 02:19:48PM -0700, Alexander Duyck wrote:
>
> On 03/10/2015 02:04 PM, Dan Carpenter wrote:
> >Hello Alexander Duyck,
> >
> >The patch dc35dbeda3e0: "fib_trie: Add tnode struct as a container
> >for fields not needed in key_vector" from Mar 6, 2015, leads to the
> >following static checker warnings:
> >
> >net/ipv4/fib_trie.c:330 leaf_new() warn: variable dereferenced before check 'kv' (see line 328)
> >net/ipv4/fib_trie.c:358 tnode_new() warn: variable dereferenced before check 'tnode' (see line 350)
>
> These two I am aware of, they are both false errors. I am not
> actually dereferencing so much as getting a pointer to an offset
> inside the structure. Think of it as an inverse offsetof().
Oh, right. I always forget about this possibility. I'll see if I can
fix the checker to not warn about these.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-10 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 21:04 fib_trie: Add tnode struct as a container for fields not needed in key_vector Dan Carpenter
2015-03-10 21:19 ` Alexander Duyck
2015-03-10 21:24 ` Dan Carpenter [this message]
2015-03-10 21:36 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310212434.GD16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.