From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro
Date: Wed, 11 Mar 2015 11:45:38 +0300 [thread overview]
Message-ID: <20150311084538.GT10964@mwanda> (raw)
In-Reply-To: <1426015760-8492-2-git-send-email-giedrius.statkevicius@gmail.com>
On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote:
> static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr, char *buf)
> {
> - struct dgnc_board *bd;
> - int count = 0;
> - int i = 0;
> -
> - DGNC_VERIFY_BOARD(p, bd);
> + int count = 0, i = 0;
Don't redo the patch, but really these should be on separate lines.
This is an unwritten rule. :) Also there is no need to set "i".
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-11 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 19:29 [PATCH 1/3] dgnc: Remove unneeded dgnc_state array of strings Giedrius Statkevičius
2015-03-10 19:29 ` [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro Giedrius Statkevičius
2015-03-11 8:45 ` Dan Carpenter [this message]
2015-03-12 10:13 ` Greg KH
2015-03-10 19:29 ` [PATCH 3/3] dgnc: clean up comments at start of files Giedrius Statkevičius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311084538.GT10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=giedrius.statkevicius@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.