Re: [tegrarcm PATCH 1/2] tegrarcm: Add Tegra132 support

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

On Tue, Jan 13, 2015 at 04:20:01PM -0800, Jimmy Zhang wrote:
> From: Allen Martin <amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> Add Tegra132 USB device id, miniloader, and chip SKU information.
> 
> Signed-off-by: Allen Martin <amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

As far as I remember Allen's original work included workarounds for an
backwards-incompatibility that was introduced in an early version of the
NV3P protocol for Tegra132. Does the miniloader included here no longer
have that incompatibility?

> ---
>  src/Makefile.am                      |    1 +
>  src/main.c                           |   15 +-
>  src/miniloader/tegra132-miniloader.h | 5259 ++++++++++++++++++++++++++++++++++
>  src/nv3p.h                           |    3 +
>  src/tegrarcm.1.in                    |    4 +-
>  src/usb.c                            |    3 +-
>  src/usb.h                            |    1 +
>  7 files changed, 5283 insertions(+), 3 deletions(-)
>  create mode 100644 src/miniloader/tegra132-miniloader.h
[...]
> diff --git a/src/miniloader/tegra132-miniloader.h b/src/miniloader/tegra132-miniloader.h
> new file mode 100644
> index 000000000000..2e8a7e8d20b6
> --- /dev/null
> +++ b/src/miniloader/tegra132-miniloader.h
> @@ -0,0 +1,5259 @@
> +/*
> + * Copyright (c) 2011 NVIDIA CORPORATION.  All Rights Reserved.

Was this file really generated in 2011? We released the chip in early
2014, so it's quite unlikely the miniloader existed 3 years before that.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]