From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] clk: provide clk_is_match() dummy for non-common clk Date: Wed, 11 Mar 2015 12:17:55 +0100 Message-ID: <20150311111755.GI952@pengutronix.de> References: <1424876018-17852-1-git-send-email-shawn.guo@linaro.org> <1424876018-17852-2-git-send-email-shawn.guo@linaro.org> <20150225172757.421.43718@quantum> <8682755.oK0Ae34OOP@wuerfel> <20150311102208.GX8656@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20150311102208.GX8656@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: linux-pwm@vger.kernel.org, alsa-devel@alsa-project.org, Mike Turquette , linux-serial@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , Stephen Boyd , dri-devel@lists.freedesktop.org, Mark Brown , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org SGV5IFJ1c3NlbGwsCgpPbiBXZWQsIE1hciAxMSwgMjAxNSBhdCAxMDoyMjowOUFNICswMDAwLCBS dXNzZWxsIEtpbmcgLSBBUk0gTGludXggd3JvdGU6Cj4gT24gU3VuLCBNYXIgMDgsIDIwMTUgYXQg MTA6MDU6MjlQTSArMDEwMCwgQXJuZCBCZXJnbWFubiB3cm90ZToKPiA+IEFSTSByYW5kY29uZmln IGJ1aWxkIHRlc3RzIGZvdW5kIGEgbmV3IGVycm9yIGZvciBjb25maWd1cmF0aW9ucwo+ID4gd2l0 aCBDT01NT05fQ0xLIGRpc2FibGVkIGJ1dCBIQVNfQ0xLIHNlbGVjdGVkIGJ5IHRoZSBwbGF0Zm9y bToKPiA+IAo+ID4gRVJST1I6ICJjbGtfaXNfbWF0Y2giIFtzb3VuZC9zb2MvZnNsL3NuZC1zb2Mt ZnNsLXNwZGlmLmtvXSB1bmRlZmluZWQhCj4gPiAKPiA+IFRoaXMgbW92ZXMgdGhlIGRlY2xhcmF0 aW9uIGFyb3VuZCwgc28gdGhpcyBjYXNlIGlzIGNvdmVyZWQKPiA+IGJ5IHRoZSBleGlzdGluZyBz dGF0aWMgaW5saW5lIGhlbHBlciBmdW5jdGlvbi4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQXJu ZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KPiA+IEZpeGVzOiBjNjllMTgyZTUxZDg5ICgiY2xr OiBpbnRyb2R1Y2UgY2xrX2lzX21hdGNoIikKPiA+IC0tLS0KPiA+IEJUVywgd2UgaGF2ZSBhIHBy ZWV4aXN0aW5nIHByb2JsZW0gaW4gY2xrX2dldF9wYXJlbnQsCj4gPiBjbGtfcm91bmRfcmF0ZSBh bmQgY2xrX3NldF9wYXJlbnQsIHdoaWNoIEkndmUgd29ya2VkIGFyb3VuZCBpbgo+ID4gbXkgcmFu ZGNvbmZpZyBidWlsZHMgc28gZmFyLiBTaG91bGQgd2UgZG8gdGhhdCB0aGUgc2FtZSB3YXk/Cj4g Cj4gTkFLLCBhcyBVd2UgcG9pbnRzIG91dCwgeW91IGRpZG4ndCBhZGRyZXNzIG15IGNvbW1lbnQu CllvdSBjb21tZW50ZWQgb24gdGhlIHBhdGNoIHRoYXQgaXMgYzY5ZTE4MmU1MWQ4ICgiY2xrOiBp bnRyb2R1Y2UKY2xrX2lzX21hdGNoIikgbm93IGluIG5leHQuIEFybmQganVzdCBtb3ZlZCB0aGlz IGFyb3VuZC4KCkJlc3QgcmVnYXJkcwpVd2UKCi0tIApQZW5ndXRyb25peCBlLksuICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCBVd2UgS2xlaW5lLUvDtm5pZyAgICAgICAgICAgIHwKSW5kdXN0 cmlhbCBMaW51eCBTb2x1dGlvbnMgICAgICAgICAgICAgICAgIHwgaHR0cDovL3d3dy5wZW5ndXRy b25peC5kZS8gIHwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Wed, 11 Mar 2015 12:17:55 +0100 Subject: [PATCH] clk: provide clk_is_match() dummy for non-common clk In-Reply-To: <20150311102208.GX8656@n2100.arm.linux.org.uk> References: <1424876018-17852-1-git-send-email-shawn.guo@linaro.org> <1424876018-17852-2-git-send-email-shawn.guo@linaro.org> <20150225172757.421.43718@quantum> <8682755.oK0Ae34OOP@wuerfel> <20150311102208.GX8656@n2100.arm.linux.org.uk> Message-ID: <20150311111755.GI952@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hey Russell, On Wed, Mar 11, 2015 at 10:22:09AM +0000, Russell King - ARM Linux wrote: > On Sun, Mar 08, 2015 at 10:05:29PM +0100, Arnd Bergmann wrote: > > ARM randconfig build tests found a new error for configurations > > with COMMON_CLK disabled but HAS_CLK selected by the platform: > > > > ERROR: "clk_is_match" [sound/soc/fsl/snd-soc-fsl-spdif.ko] undefined! > > > > This moves the declaration around, so this case is covered > > by the existing static inline helper function. > > > > Signed-off-by: Arnd Bergmann > > Fixes: c69e182e51d89 ("clk: introduce clk_is_match") > > ---- > > BTW, we have a preexisting problem in clk_get_parent, > > clk_round_rate and clk_set_parent, which I've worked around in > > my randconfig builds so far. Should we do that the same way? > > NAK, as Uwe points out, you didn't address my comment. You commented on the patch that is c69e182e51d8 ("clk: introduce clk_is_match") now in next. Arnd just moved this around. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |