From: Greg KH <greg@kroah.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Pavel Machek <pavel@ucw.cz>,
kernel list <linux-kernel@vger.kernel.org>,
linux-pcmcia@lists.infradead.org, axboe@kernel.dk
Subject: Re: [solution exits] no PCMCIA in 4.0-rc3
Date: Wed, 11 Mar 2015 14:33:22 +0100 [thread overview]
Message-ID: <20150311133322.GA16209@kroah.com> (raw)
In-Reply-To: <20150310215613.3bf7913b@lxorguk.ukuu.org.uk>
On Tue, Mar 10, 2015 at 09:56:13PM +0000, One Thousand Gnomes wrote:
> On Tue, 10 Mar 2015 21:31:58 +0100
> > > Probably a PCMCIA not a block layer change - well I guess could be
> > > either. I fixed a pile of PCMCIA bugs and also reworked the allocator for
> > > pure PCI boxes so it didn't do various bad things.
> > >
> > > Can you tweak drivers/pcmcia/Kconfig for config YENTA and make
> > >
> > > select PCCARD_PCI if PCMCIA !=n && !ISA
> > >
> > > instead do
> > >
> > > select PCCARD_NONSTATIC if PCMCIA !=n && !ISA
> > >
> > > rebuild and re-test
> >
> > If I do that, it breaks compile. If I do that, and delete "config
> > PCCARD_PCI", it fixes PCMCIA. Thanks!
>
> Greg - can you revert
>
> commit 02b03846bb2befc558bfd0665749d6bb26f4c2f1
> Author: Alan Cox <alan@linux.intel.com>
> Date: Wed Dec 10 15:07:36 2014 +0000
>
> pcmcia: add a new resource manager for non ISA systems
>
> On a pure PCI platform we don't actually need all the complexity of
> the rsrc_nonstatic manager, in fact we can just work directly with
> the pci allocators and avoid all the complexity (and code bloat).
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
>
> and the one on top of it
>
> commit d885d4f3728f386034bb2f7a61b7f2054c49b2d4
> Author: Arnd Bergmann <arnd@arndb.de>
> Date: Tue Jan 13 15:11:55 2015 +0100
>
> pcmcia: add missing include for new pci resource handler
>
> The recently added rsrc_pci.c file calls pci_bus_alloc_resource without
> including the header file that declares it, and that sometimes causes
> a build warning on ARM:
>
> drivers/pcmcia/rsrc_pci.c: In function 'find_io_region':
> drivers/pcmcia/rsrc_pci.c:40:2: error: implicit declaration of function 'pci_bus_alloc_resource' [-Werror=implicit-function-declaration]
>
> This adds the missing include statement.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 02b03846bb2be ("pcmcia: add a new resource manager for non ISA systems")
> Acked-by: Alan Cox <alan@linux.intel.com>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
>
> as it seems there is a regression in there for some configuration of I/O
> based devices. I'll take a look at it over the next couple of kernel
> releases and see what is up then resubmit it with fixes.
Now reverted, thanks.
greg k-h
next prev parent reply other threads:[~2015-03-11 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 23:08 4.0-rc1: Oops on eject of CF card in PCMCIA slot Pavel Machek
2015-03-02 11:57 ` One Thousand Gnomes
2015-03-09 20:57 ` Pavel Machek
2015-03-09 21:11 ` Pavel Machek
2015-03-10 20:31 ` [solution exits] no PCMCIA in 4.0-rc3 Pavel Machek
2015-03-10 21:56 ` One Thousand Gnomes
2015-03-11 13:33 ` Greg KH [this message]
2015-03-10 11:48 ` 4.0-rc2+: PATA CF card not detected in PCMCIA slot Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311133322.GA16209@kroah.com \
--to=greg@kroah.com \
--cc=axboe@kernel.dk \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.