From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: davem@davemloft.net, linux-aio@kvack.org,
herbert@gondor.apana.org.au, netdev@vger.kernel.org,
ying.xue@windriver.com, bcrl@kvack.org,
linux-fsdevel@vger.kernel.org, hch@lst.de,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH RFC 2/4] aio: prefer aio_op op over iter_op
Date: Thu, 12 Mar 2015 06:48:25 +0000 [thread overview]
Message-ID: <20150312064825.GL29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150311224618.23777.38330.stgit@tstruk-mobl1>
On Wed, Mar 11, 2015 at 03:46:18PM -0700, Tadeusz Struk wrote:
> AIO interface should prefer AIO operations over iter_op
What the devil for? read_iter and write_iter *ARE* aio operations, as much
as soon to be removed aio_read and aio_write. And yes, those are going to
be removed very soon.
Note that ->read_iter() and ->write_iter() are getting iocb pointer passed
to them. It's just that socket instances are not passing it along to
->sendmsg/->recvmsg anymore.
And why, in name of everything unholy, do your methods get redundant
total_len argument? It's iov_iter_count(&msg->msg_iter) (and in iov_iter-net
I have an inline helper doing that - enough places open-coding that thing).
If nothing else, ->sendmsg() and ->recvmsg() would benefit from removing
that argument as well. I have patches doing that, but iocb removal conflicts
with them and they need to be rebased to current net/master...
next prev parent reply other threads:[~2015-03-12 6:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 22:46 [PATCH RFC 0/4] Add support for async socket operations Tadeusz Struk
2015-03-11 22:46 ` [PATCH RFC 1/4] net: socket: add support for async operations Tadeusz Struk
2015-03-11 22:46 ` [PATCH RFC 2/4] aio: prefer aio_op op over iter_op Tadeusz Struk
2015-03-12 6:48 ` Al Viro [this message]
2015-03-12 14:00 ` Tadeusz Struk
2015-03-11 22:46 ` [PATCH RFC 3/4] crypto: af_alg - Allow to link sgl Tadeusz Struk
2015-03-11 22:46 ` [PATCH RFC 4/4] crypto: algif - change algif_skcipher to be asynchronous Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312064825.GL29656@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bcrl@kvack.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-aio@kvack.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.