From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753730AbbCLLBr (ORCPT ); Thu, 12 Mar 2015 07:01:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42119 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753309AbbCLLBo (ORCPT ); Thu, 12 Mar 2015 07:01:44 -0400 Date: Thu, 12 Mar 2015 12:01:27 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , LKML , David Ahern , Minchan Kim , Joonsoo Kim Subject: Re: [PATCH 4/6] perf kmem: Analyze page allocator events also Message-ID: <20150312110127.GD8369@krava.redhat.com> References: <1426145571-3065-1-git-send-email-namhyung@kernel.org> <1426145571-3065-5-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426145571-3065-5-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 04:32:49PM +0900, Namhyung Kim wrote: SNIP > +static int parse_slab_opt(const struct option *opt __maybe_unused, > + const char *arg __maybe_unused, > + int unset __maybe_unused) > +{ > + kmem_slab = (kmem_page + 1); > + return 0; > +} > + > +static int parse_page_opt(const struct option *opt __maybe_unused, > + const char *arg __maybe_unused, > + int unset __maybe_unused) > +{ > + kmem_page = (kmem_slab + 1); > + return 0; > +} hum, just curious.. why not just assign 1, I'm missing the magic ;-) thanks, jirk