From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH V6 01/13] xen/mem_event: Cleanup of
	mem_event structures
Date: Thu, 12 Mar 2015 13:13:37 +0100
Message-ID: <20150312121337.GC22158@deinos.phlegethon.org>
References: <1424218303-11331-1-git-send-email-tamas.lengyel@zentific.com>
	<1424218303-11331-2-git-send-email-tamas.lengyel@zentific.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1424218303-11331-2-git-send-email-tamas.lengyel@zentific.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, steve@zentific.com, stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, andres@lagarcavilla.org, jbeulich@suse.com, rshriram@cs.ubc.ca, keir@xen.org, dgdegra@tycho.nsa.gov, yanghy@cn.fujitsu.com, Razvan Cojocaru <rcojocaru@bitdefender.com>
List-Id: xen-devel@lists.xenproject.org

At 01:11 +0100 on 18 Feb (1424218291), Tamas K Lengyel wrote:
> +struct mem_event_mem_access {
>      uint64_t gfn;
>      uint64_t offset;
> -    uint64_t gla; /* if gla_valid */
> +    uint64_t gla;   /* if flags has MEM_ACCESS_GLA_VALID set */
> +    uint32_t flags; /* MEM_ACCESS_* */
> +    uint32_t _pad;
> +};
> +
> +struct mem_event_mov_to_cr {
> +    uint64_t new_value;
> +    uint64_t old_value;
> +};
> +
> +struct mem_event_debug {
> +    uint64_t gfn;
> +};
>  
> +struct mem_event_mov_to_msr {
> +    uint64_t msr;
> +    uint64_t value;
> +};
> +
> +#define MEM_PAGING_DROP_PAGE       (1 << 0)
> +#define MEM_PAGING_EVICT_FAIL      (1 << 1)
> +
> +struct mem_event_paging {
> +    uint64_t gfn;
>      uint32_t p2mt;
> +    uint32_t flags;
> +};
> +
> +struct mem_event_sharing {
> +    uint64_t gfn;
> +    uint32_t p2mt;
> +};

I see you have padded struct mem_event_mem_access to an 8-byte
boundary but not this -- given the union I suppose it makes no
difference but it woud be consistent to add padding here too.

In any case,

Acked-by: Tim Deegan <tim@xen.org>

Tim.