From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by arago-project.org (Postfix) with ESMTPS id 1287752A78 for ; Thu, 12 Mar 2015 14:13:26 +0000 (UTC) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id t2CEDPBV029146 for ; Thu, 12 Mar 2015 09:13:25 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id t2CEDOkC005186 for ; Thu, 12 Mar 2015 09:13:24 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.224.2; Thu, 12 Mar 2015 09:13:24 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id t2CEDNSA016538; Thu, 12 Mar 2015 09:13:24 -0500 Date: Thu, 12 Mar 2015 10:13:23 -0400 From: Denys Dmytriyenko To: "Stiffler, Jacob" Message-ID: <20150312141323.GE24885@edge> References: <1426164957-22030-1-git-send-email-j-stiffler@ti.com> <1426164957-22030-3-git-send-email-j-stiffler@ti.com> <20150312135554.GB24885@edge> <4B26FB5A64EBA14C87266869E037F95814107DC6@DFLE09.ent.ti.com> MIME-Version: 1.0 In-Reply-To: <4B26FB5A64EBA14C87266869E037F95814107DC6@DFLE09.ent.ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "meta-arago@arago-project.org" Subject: Re: [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa. X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2015 14:13:26 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Thu, Mar 12, 2015 at 09:58:38AM -0400, Stiffler, Jacob wrote: > I'm not sure of the history, it just seemed more complete to only depend on > wayland if wayland is a feature. Yeah, it makes sense logically, but unfortunately the way GFX SDK is built it will break w/o wayland libs, I'm afraid. > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Thursday, March 12, 2015 9:56 AM > To: Stiffler, Jacob > Cc: meta-arago@arago-project.org > Subject: Re: [meta-arago] [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa. > > On Thu, Mar 12, 2015 at 08:55:55AM -0400, Jacob Stiffler wrote: > > * If wayland is in DISTRO_FEATURES, then configure '-qpa wayland' > > * Otherwise configure '-qpa eglfs' > > > > Signed-off-by: Jacob Stiffler > > --- > > meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh | 1 - > > .../recipes-qt/qt5/qtbase_5.4.1.bbappend | 9 ++++++--- > > 2 files changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh > > b/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh > > index 1e8c196..f888d50 100644 > > --- a/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh > > +++ b/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh > > @@ -2,4 +2,3 @@ > > > > ### QT Environment Variables ### > > export QT_QPA_GENERIC_PLUGINS=Auto > > -export QT_QPA_PLATFORM=wayland > > diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend > > b/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend > > index a466581..5a00800 100644 > > --- a/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend > > +++ b/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend > > @@ -1,13 +1,16 @@ > > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > > > > GLES_EXTRA_DEPS = "" > > -GLES_EXTRA_DEPS_omap-a15 = "libdrm wayland" > > +GLES_EXTRA_DEPS_omap-a15 = " \ > > + libdrm \ > > + ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} > > +\ " > > I meant to comment to the previous revision about this part above ^^^ I don't think it will work (not that it will be tested) - the way OMAP5 GFX is built, it has hardcoded dependency on wayland libs, hence it's added above... > That said, I'm not sure you can get eglfs on OMAP5 platforms working cleanly w/o any wayland libs. But aren't you only doing it for AM3/4 anyway? > > > > PACKAGECONFIG[gles2] = "-opengl es2 -eglfs,,virtual/libgles2 virtual/egl ${GLES_EXTRA_DEPS}" > > > > -PR_append = "-arago3" > > +PR_append = "-arago4" > > > > -QT_CONFIG_FLAGS += "-qpa wayland" > > +QT_CONFIG_FLAGS += "-qpa ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', 'eglfs', d)}" > > > > SRC_URI += "file://qt_env.sh" > > > > -- > > 1.7.9.5 > > > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago