Re: [PATCH v7] af_packet: Fix some klocwork errors

["John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>]

On Thu, Mar 12, 2015 at 09:38:46AM -0400, Neil Horman wrote:
> On Thu, Mar 12, 2015 at 10:43:24AM +0000, Qiu, Michael wrote:
> > On 3/11/2015 9:34 AM, Ouyang Changchun wrote:
> > > Fix possible memory leak issue: free kvlist before return;
> > > Fix possible resource lost issue: close qssockfd before return;
> > >
> > > Signed-off-by: Changchun Ouyang <changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > ---
> > > Change in v7:
> > >   - Remove unnecessary '!= NULL' check before freeing it; 
> > >
> > > Change in v6:
> > >   - Refine exit point;
> > >  
> > > Change in v5:
> > >   - Initialize qsockfd with -1;
> > >  
> > > Change in v4:
> > >   - Check sockfd in internals->rx_queue against 0;
> > >  
> > > Change in v3:
> > >   - Also close sockets for all queues;
> > >  
> > > Change in v2:
> > >   - Make the error exit point a common path.
> > 
> > Acked-by: Michael Qiu <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Acked-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>

Acked-by: John W. Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>

-- 
John W. Linville		Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org			might be all we have.  Be ready.