From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John W. Linville" Subject: Re: [PATCH v7] af_packet: Fix some klocwork errors Date: Thu, 12 Mar 2015 13:09:19 -0400 Message-ID: <20150312170919.GA19053@tuxdriver.com> References: <1425958188-25041-1-git-send-email-changchun.ouyang@intel.com> <1426037641-4515-1-git-send-email-changchun.ouyang@intel.com> <533710CFB86FA344BFBF2D6802E60286D02B43@SHSMSX101.ccr.corp.intel.com> <20150312133846.GA15260@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Neil Horman Return-path: Content-Disposition: inline In-Reply-To: <20150312133846.GA15260-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, Mar 12, 2015 at 09:38:46AM -0400, Neil Horman wrote: > On Thu, Mar 12, 2015 at 10:43:24AM +0000, Qiu, Michael wrote: > > On 3/11/2015 9:34 AM, Ouyang Changchun wrote: > > > Fix possible memory leak issue: free kvlist before return; > > > Fix possible resource lost issue: close qssockfd before return; > > > > > > Signed-off-by: Changchun Ouyang > > > --- > > > Change in v7: > > > - Remove unnecessary '!= NULL' check before freeing it; > > > > > > Change in v6: > > > - Refine exit point; > > > > > > Change in v5: > > > - Initialize qsockfd with -1; > > > > > > Change in v4: > > > - Check sockfd in internals->rx_queue against 0; > > > > > > Change in v3: > > > - Also close sockets for all queues; > > > > > > Change in v2: > > > - Make the error exit point a common path. > > > > Acked-by: Michael Qiu > Acked-by: Neil Horman Acked-by: John W. Linville -- John W. Linville Someday the world will need a hero, and you linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org might be all we have. Be ready.