From: Liu Bo <bo.li.liu@oracle.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org, Eryu Guan <guaneryu@gmail.com>
Subject: Re: [PATCH] Revert "Btrfs: allow superblock mismatch from older mkfs"
Date: Fri, 13 Mar 2015 04:09:36 +0800 [thread overview]
Message-ID: <20150312200935.GA10724@localhost.localdomain> (raw)
In-Reply-To: <20150312172513.GD20767@twin.jikos.cz>
On Thu, Mar 12, 2015 at 06:25:13PM +0100, David Sterba wrote:
> On Thu, Mar 12, 2015 at 01:40:47PM +0800, Liu Bo wrote:
> > This reverts commit 667e7d94a1683661cff5fe9a0fa0d7f8fdd2c007.
> >
> > This was used to make sure that a fresh btrfs from an older mkfs.btrfs,
> > and it also allows us to mount a buggy btrfs if this btrfs has the right
> > superblock head part but has something wrong with chunk tree part[1], and
> > after that we can hit BUG_ON()s set in the code to prevent something
> > impossible.
> >
> > Since David has gave us "Btrfs progs v3.19-rc2", just remove the check,
> > if anyone who wants to make a fresh btrfs, please use the latest one.
>
> I think the fixed progs are out long enough and the combination of
> really old progs + really new kernel is very uncommon and we don't need
> to care about that anymore.
>
> However, please do not do it as a revert, it's a normal patch although
> it effectively reverts some other patch.
Okay, I'll update this ASAP, thanks for your review.
Thanks,
-liubo
prev parent reply other threads:[~2015-03-12 20:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 5:40 [PATCH] Revert "Btrfs: allow superblock mismatch from older mkfs" Liu Bo
2015-03-12 5:45 ` Qu Wenruo
2015-03-12 17:34 ` David Sterba
2015-03-12 20:15 ` Liu Bo
2015-03-16 16:25 ` David Sterba
2015-03-17 2:41 ` Qu Wenruo
2015-03-17 6:34 ` [PATCH v2] Btrfs: Remove the check for old-style mkfs Liu Bo
2015-03-17 7:13 ` Omar Sandoval
2015-03-17 10:11 ` David Sterba
2015-03-12 17:25 ` [PATCH] Revert "Btrfs: allow superblock mismatch from older mkfs" David Sterba
2015-03-12 20:09 ` Liu Bo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312200935.GA10724@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=guaneryu@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.