From: Bob Copeland <me@bobcopeland.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: linux-kernel@vger.kernel.org,
"open list:OMFS FILESYSTEM"
<linux-karma-devel@lists.sourceforge.net>
Subject: Re: [PATCH] fs, omfs: add NULL terminator in the end up the token list
Date: Thu, 12 Mar 2015 16:24:08 -0400 [thread overview]
Message-ID: <20150312202408.GF9840@localhost> (raw)
In-Reply-To: <1426191071-765-1-git-send-email-sasha.levin@oracle.com>
On Thu, Mar 12, 2015 at 04:11:09PM -0400, Sasha Levin wrote:
> match_token() expects a NULL terminator at the end of the token list so that
> it would know where to stop. Not having one causes it to overrun to invalid
> memory.
>
> In practice, passing a mount option that omfs didn't recognize would sometimes
> panic the system.
Yikes, thanks for the catch!
Acked-by: Bob Copeland <me@bobcopeland.com>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
--
Bob Copeland %% http://bobcopeland.com/
prev parent reply other threads:[~2015-03-12 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 20:11 [PATCH] fs, omfs: add NULL terminator in the end up the token list Sasha Levin
2015-03-12 20:24 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312202408.GF9840@localhost \
--to=me@bobcopeland.com \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.