All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nitin Gupta <ngupta@vflare.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes
Date: Fri, 13 Mar 2015 17:16:25 +0900	[thread overview]
Message-ID: <20150313081625.GA410@swordfish> (raw)
In-Reply-To: <20150313073908.GA9753@blaptop>

On (03/13/15 16:39), Minchan Kim wrote:
> AFAIK, kernel rule doesn't prefer multi-line for printk string
> because it makes hard to work with grep. Anyway, it's trivial.
> For example, checkpatch will emit
> 
> WARNING: quoted string split across lines
> 

yes, exactly. that's why I mentioned it in the first place.


well... something like this (a bit ugly, but can do the trick):

pr_warn_once("%d (%s): Attribute %s (and others) will be removed. %s\n"
                       task_pid_nr(current),
                       current->comm,
                       name,
                       "See zram documentation.");

will resend the patch later today.

> Anyway, I agree with your way.

thanks for review!

	-ss

      reply	other threads:[~2015-03-13  8:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 14:47 [PATCHv2 0/7] new zram statistics reporting scheme Sergey Senozhatsky
2015-03-12 14:47 ` [PATCHv2 1/7] zram: remove `num_migrated' device attr Sergey Senozhatsky
2015-03-12 14:47 ` [PATCHv2 2/7] zram: move compact_store() to sysfs functions area Sergey Senozhatsky
2015-03-12 14:47 ` [PATCHv2 3/7] zram: use generic start/end io accounting Sergey Senozhatsky
2015-03-12 14:47 ` [PATCHv2 4/7] zram: describe device attrs in documentation Sergey Senozhatsky
2015-03-12 14:47 ` [PATCHv2 5/7] zram: export new 'io_stat' sysfs attrs Sergey Senozhatsky
2015-03-12 14:47 ` [PATCHv2 6/7] zram: export new 'mm_stat' " Sergey Senozhatsky
2015-03-12 14:47 ` [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes Sergey Senozhatsky
2015-03-12 23:55   ` Minchan Kim
2015-03-13  1:10     ` Sergey Senozhatsky
2015-03-13  7:39       ` Minchan Kim
2015-03-13  8:16         ` Sergey Senozhatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150313081625.GA410@swordfish \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.