From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWOdP-0002U7-55 for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:24:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWOdM-0007Xn-FY for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:24:11 -0400 Received: from smtp3.mundo-r.com ([212.51.32.191]:26289 helo=smtp4.mundo-r.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWOdM-0007Ni-9S for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:24:08 -0400 Date: Fri, 13 Mar 2015 13:23:29 +0100 From: Alberto Garcia Message-ID: <20150313122329.GA9419@igalia.com> References: <1426228529-15969-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426228529-15969-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block/throttle: Use host clock type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , pbonzini@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi On Fri, Mar 13, 2015 at 02:35:29PM +0800, Fam Zheng wrote: > Throttle timers won't make any progress when VCPU is not running, > which is prone to stall the request queue in cases like utils, > qtest, suspending, and live migration, unless carefully handled. Yes, this can be easily reproduced by stopping the VM and starting a block-commit job. If the I/O in that device is throttled then the job will be stalled. Then there's also the situation that we discussed in IRC: if the block-commit job is ongoing and then we stop the VM, then the rest of the data will be committed bypassing the throttling settings. But that's not related to these changes. > Signed-off-by: Fam Zheng > --- > block.c | 2 +- > tests/test-throttle.c | 14 +++++++------- > 2 files changed, 8 insertions(+), 8 deletions(-) Reviewed-By: Alberto Garcia Berto