From: der.herr@hofr.at (Nicholas Mc Guire)
To: kernelnewbies@lists.kernelnewbies.org
Subject: CHECK: Alignment should match open parenthesis
Date: Fri, 13 Mar 2015 13:43:32 +0100 [thread overview]
Message-ID: <20150313124332.GA22044@opentech.at> (raw)
In-Reply-To: <609013997.1677493.1426248436227.JavaMail.yahoo@mail.yahoo.com>
On Fri, 13 Mar 2015, palik imre wrote:
> Sorry for the silly question, but I have some issues with this checkpatch.pl warning.
>
> I mean Documentation/CodingStyle says:
>
> Outside of comments, documentation and except in Kconfig, spaces are never
> used for indentation, and the above example is deliberately broken.
>
> But checkpatch.pl claims I should align to open parentheses. These two things seem to be contradictory to me. Could somebody clarify this?
>
leading tabs *followed* by spaces to align parameters to a function are fine
but for basic block indentation you never use spaces. so
func(param1,
param2);
would be allowed but not
if (something) {
if(something else) {
HTH
thx!
hofrat
next prev parent reply other threads:[~2015-03-13 12:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 12:07 CHECK: Alignment should match open parenthesis palik imre
2015-03-13 12:43 ` Nicholas Mc Guire [this message]
2015-03-13 13:09 ` palik imre
2015-03-13 13:28 ` Nicholas Mc Guire
2015-03-13 13:47 ` Nicholas Mc Guire
2015-03-13 14:35 ` Daniel Baluta
2015-03-13 14:46 ` Greg KH
2015-03-13 15:33 ` Nicholas Mc Guire
2015-03-13 16:15 ` Daniel Baluta
2015-03-13 16:46 ` Jeff Haran
2015-03-13 16:58 ` Nicholas Mc Guire
2015-03-13 17:18 ` Jeff Haran
2015-03-13 17:31 ` Nicholas Mc Guire
2015-03-13 18:05 ` Jeff Haran
2015-03-13 18:57 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313124332.GA22044@opentech.at \
--to=der.herr@hofr.at \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.