All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86/kexec: Cleanup KEXEC_VERIFY_SIG Kconfig help text
Date: Fri, 13 Mar 2015 09:13:24 -0400	[thread overview]
Message-ID: <20150313131324.GA21790@redhat.com> (raw)
In-Reply-To: <1426251877-11415-1-git-send-email-bp@alien8.de>

On Fri, Mar 13, 2015 at 02:04:37PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> Make it much simpler without losing the gist of what it says.
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Vivek Goyal <vgoyal@redhat.com>
> ---
>  arch/x86/Kconfig | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 8f829ffb9003..8db84b0e5bbd 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1775,14 +1775,11 @@ config KEXEC_VERIFY_SIG
>  	depends on KEXEC_FILE
>  	---help---
>  	  This option makes kernel signature verification mandatory for
> -	  kexec_file_load() syscall. If kernel is signature can not be
> -	  verified, kexec_file_load() will fail.
> -
> -	  This option enforces signature verification at generic level.
> -	  One needs to enable signature verification for type of kernel
> -	  image being loaded to make sure it works. For example, enable
> -	  bzImage signature verification option to be able to load and
> -	  verify signatures of bzImage. Otherwise kernel loading will fail.
> +	  the kexec_file_load() syscall.
> +
> +	  In addition to that option, you need to enable signature
> +	  verification for the corresponding kernel image type being
> +	  loaded in order for this to work.
>  

Hmm..., I find even previous text to be just fine. But as I wrote it, I
might be biased. So I will leave it to others to decide.

Thanks
Vivek

  reply	other threads:[~2015-03-13 13:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 13:04 [PATCH] x86/kexec: Cleanup KEXEC_VERIFY_SIG Kconfig help text Borislav Petkov
2015-03-13 13:13 ` Vivek Goyal [this message]
2015-03-13 14:29   ` Borislav Petkov
2015-03-16 12:07 ` [tip:x86/build] " tip-bot for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150313131324.GA21790@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.