From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 1/6] x86: detect and initialize Intel CAT
 feature
Date: Fri, 13 Mar 2015 09:43:00 -0400
Message-ID: <20150313134300.GA7719@l.oracle.com>
References: <1426241605-4114-1-git-send-email-chao.p.peng@linux.intel.com>
	<1426241605-4114-2-git-send-email-chao.p.peng@linux.intel.com>
	<20150313134013.GE5378@l.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20150313134013.GE5378@l.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Chao Peng <chao.p.peng@linux.intel.com>
Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, JBeulich@suse.com, wei.liu2@citrix.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

> > +    cat_cpu_init(smp_processor_id());
> 
> Do 'if (!cat_cpu_init(..)).`'
> 
> as the CPU might not support this.
> 
> At which point you should also free the cat_socket_info and

And also set cat_socket_info = NULL.
> not register the cpu notifier.
> 
> > +    register_cpu_notifier(&cpu_nfb);