All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
	Jan Kratochvil <jan.kratochvil@redhat.com>,
	GDB Patches <gdb-patches@sourceware.org>,
	Pedro Alves <palves@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: vvar, gup && coredump
Date: Fri, 13 Mar 2015 16:04:17 +0100	[thread overview]
Message-ID: <20150313150417.GE21603@redhat.com> (raw)
In-Reply-To: <87zj7hlcuv.fsf@redhat.com>

On 03/13, Sergio Durigan Junior wrote:
>
> On Thursday, March 12 2015, Oleg Nesterov wrote:
>
> > And it seems that we all agree that the kernel should not dump this vma
> > too. Could you confirm that this is fine from gdb pov just in case?
>
> Yes, this is what we expect from the GDB side.  This mapping is marked
> as "dd", so it does not make sense to dump it.

OK.

> While I have you guys, would it be possible for the Linux kernel to
> include a new flag on VmFlags to uniquely identify an anonymous mapping?

Note that "anonymous" is not the right term here... I mean it is a bit
confusing. Lets discuss this again on debug-list, then we will see if
gdb needs more info from kernel.

> Currently, there is no easy way to do that from userspace.  My patch
> implements the following heuristic on GDB:
>
>   if (pathname == "/dev/zero (deleted)"
>       || pathname == "/SYSV%08x (deleted)"
>       || pathname == "<file> (deleted)"

And for example, this is not anonymous mapping. But,

>     mapping is anonymous;

I agree, gdb should treat it as anonymous.

> However, this can be fragile.  The Linux kernel checks for i_nlink == 0,

Yes, as we already disccussed, I think the kernel should be changed.

It should do something like shmem_mapping() || d_unlinked(), I think.
But this needs another discussion on lkml, and in another thread.

Oleg.


  reply	other threads:[~2015-03-13 15:06 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <878ufc9kau.fsf@redhat.com>
     [not found] ` <20150305154827.GA9441@host1.jankratochvil.net>
     [not found]   ` <87zj7r5fpz.fsf@redhat.com>
     [not found]     ` <20150305205744.GA13165@host1.jankratochvil.net>
     [not found]       ` <20150311200052.GA22654@redhat.com>
2015-03-12 14:34         ` vvar, gup && coredump Oleg Nesterov
2015-03-12 16:29           ` Andy Lutomirski
2015-03-12 16:54             ` Oleg Nesterov
2015-03-12 17:17               ` Andy Lutomirski
2015-03-12 17:39                 ` Oleg Nesterov
2015-03-12 17:45                   ` Sergio Durigan Junior
2015-03-12 18:02                     ` Oleg Nesterov
2015-03-13  4:50                       ` Sergio Durigan Junior
2015-03-13 15:04                         ` Oleg Nesterov [this message]
2015-03-12 17:55                   ` Andy Lutomirski
2015-03-12 18:08                     ` Oleg Nesterov
2015-03-12 18:33                       ` Andy Lutomirski
2015-03-13 15:22                         ` Oleg Nesterov
2015-03-12 17:46               ` Oleg Nesterov
2015-03-12 17:54                 ` Andy Lutomirski
2015-03-12 18:05                   ` Oleg Nesterov
2015-03-12 18:23                     ` Sergio Durigan Junior
2015-03-12 18:19                 ` Pedro Alves
2015-03-12 18:25                   ` Andy Lutomirski
2015-03-16 19:01                 ` install_special_mapping && vm_pgoff (Was: vvar, gup && coredump) Oleg Nesterov
2015-03-16 19:20                   ` Andy Lutomirski
2015-03-16 19:20                     ` Andy Lutomirski
2015-03-16 19:44                     ` Oleg Nesterov
2015-03-16 19:44                       ` Oleg Nesterov
2015-03-17 13:43                       ` Oleg Nesterov
2015-03-17 13:43                         ` Oleg Nesterov
2015-03-18  1:44                         ` Andy Lutomirski
2015-03-18  1:44                           ` Andy Lutomirski
2015-03-18 18:06                           ` Oleg Nesterov
2015-03-18 18:06                             ` Oleg Nesterov
2015-03-16 19:40                   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150313150417.GE21603@redhat.com \
    --to=oleg@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=palves@redhat.com \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.