From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data Date: Fri, 13 Mar 2015 08:13:02 -0700 Message-ID: <20150313151301.GJ5264@atomide.com> References: <1426162154-8716-1-git-send-email-eliad@wizery.com> <1426162154-8716-7-git-send-email-eliad@wizery.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1426162154-8716-7-git-send-email-eliad@wizery.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Eliad Peller Cc: Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Arnd Bergmann , Ian Campbell , Enric Balletbo i Serra , Sekhar Nori , linux-wireless@vger.kernel.org, Kevin Hilman , Rob Herring , =?utf-8?Q?Beno=C3=AEt?= Cousson , Kumar Gala , Javier Martinez Canillas , linux-omap@vger.kernel.org, Luciano Coelho , linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org KiBFbGlhZCBQZWxsZXIgPGVsaWFkQHdpemVyeS5jb20+IFsxNTAzMTIgMDU6MTBdOgo+IE5vdyB0 aGF0IHdlIGhhdmUgd2xjb3JlIGRldmljZS10cmVlIGJpbmRpbmdzIGluIHBsYWNlCj4gKGZvciBi b3RoIHdsMTJ4eCBhbmQgd2wxOHh4KSwgcmVtb3ZlIHRoZSBsZWdhY3kKPiB3bDEyeHhfcGxhdGZv cm1fZGF0YSBzdHJ1Y3QsIGFuZCBtb3ZlIGl0cyBtZW1iZXJzCj4gaW50byB0aGUgcGxhdGZvcm0g ZGV2aWNlIGRhdGEgKHRoYXQgaXMgcGFzc2VkIHRvIHdsY29yZSkKPiAKPiBEYXZpbmNpIDg1MCBp cyB0aGUgb25seSBwbGF0Zm9ybSB0aGF0IHN0aWxsIHNldAo+IHRoZSBwbGF0Zm9ybSBkYXRhIGlu IHRoZSBsZWdhY3kgd2F5IChhbmQgZG9lc24ndAo+IGhhdmUgRFQgYmluZGluZ3MpLCBzbyByZW1v dmUgdGhlIHJlbGV2YW50Cj4gY29kZS9LY29uZmlnIG9wdGlvbiBmcm9tIHRoZSBib2FyZCBmaWxl IChhcyBzdWdnZXN0ZWQKPiBieSBTZWtoYXIgTm9yaSkKPiAKPiBTaWduZWQtb2ZmLWJ5OiBMdWNp YW5vIENvZWxobyA8bHVjYUBjb2VsaG8uZmk+Cj4gU2lnbmVkLW9mZi1ieTogRWxpYWQgUGVsbGVy IDxlbGlhZEB3aXplcnkuY29tPgo+IC0tLQo+ICBhcmNoL2FybS9tYWNoLWRhdmluY2kvS2NvbmZp ZyAgICAgICAgICAgICAgICAgIHwgIDExIC0tLQo+ICBhcmNoL2FybS9tYWNoLWRhdmluY2kvYm9h cmQtZGE4NTAtZXZtLmMgICAgICAgIHwgMTEzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAg ZHJpdmVycy9uZXQvd2lyZWxlc3MvdGkvd2lsaW5rX3BsYXRmb3JtX2RhdGEuYyB8ICAyNSAtLS0t LS0KPiAgZHJpdmVycy9uZXQvd2lyZWxlc3MvdGkvd2wxMnh4L21haW4uYyAgICAgICAgICB8ICAx OSArKy0tLQo+ICBkcml2ZXJzL25ldC93aXJlbGVzcy90aS93bGNvcmUvYm9vdC5jICAgICAgICAg IHwgICAxIC0KPiAgZHJpdmVycy9uZXQvd2lyZWxlc3MvdGkvd2xjb3JlL21haW4uYyAgICAgICAg ICB8ICAgNCArLQo+ICBkcml2ZXJzL25ldC93aXJlbGVzcy90aS93bGNvcmUvc2Rpby5jICAgICAg ICAgIHwgIDc1ICsrKysrLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9uZXQvd2lyZWxlc3MvdGkvd2xj b3JlL3dsY29yZV9pLmggICAgICB8ICAgOCArLQo+ICBpbmNsdWRlL2xpbnV4L3dsMTJ4eC5oICAg ICAgICAgICAgICAgICAgICAgICAgIHwgIDI1IC0tLS0tLQo+ICA5IGZpbGVzIGNoYW5nZWQsIDM2 IGluc2VydGlvbnMoKyksIDI0NSBkZWxldGlvbnMoLSkKCkkgZ290IGEgYnVpbGQgZXJyb3IgcmVs YXRlZCB0byB0aGUgU1BJIGRyaXZlciB3aXRoIHRoaXMgc2VyaWVzLCBwcm9iYWJseQpuZWVkIHRv IHVwZGF0ZSB0aGlzIHBhdGNoOgoKZHJpdmVycy9uZXQvd2lyZWxlc3MvdGkvd2xjb3JlL3NwaS5j OiBJbiBmdW5jdGlvbiDigJh3bDEyNzFfcHJvYmXigJk6CmRyaXZlcnMvbmV0L3dpcmVsZXNzL3Rp L3dsY29yZS9zcGkuYzozMzQ6MTE6IGVycm9yOiDigJhzdHJ1Y3Qgd2xjb3JlX3BsYXRkZXZfZGF0 YeKAmSBoYXMgbm8gbWVtYmVyIG5hbWVkIOKAmHBkYXRh4oCZCiAgcGRldl9kYXRhLnBkYXRhID0g ZGV2X2dldF9wbGF0ZGF0YSgmc3BpLT5kZXYpOwogICAgICAgICAgIF4KZHJpdmVycy9uZXQvd2ly ZWxlc3MvdGkvd2xjb3JlL3NwaS5jOjMzNToxNjogZXJyb3I6IOKAmHN0cnVjdCB3bGNvcmVfcGxh dGRldl9kYXRh4oCZIGhhcyBubyBtZW1iZXIgbmFtZWQg4oCYcGRhdGHigJkKICBpZiAoIXBkZXZf ZGF0YS5wZGF0YSkgewoKUmVnYXJkcywKClRvbnkKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from muru.com ([72.249.23.125]:36942 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756180AbbCMPSC (ORCPT ); Fri, 13 Mar 2015 11:18:02 -0400 Date: Fri, 13 Mar 2015 08:13:02 -0700 From: Tony Lindgren To: Eliad Peller Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , =?utf-8?Q?Beno=C3=AEt?= Cousson , Enric Balletbo i Serra , Javier Martinez Canillas , Sekhar Nori , Kevin Hilman , Luciano Coelho Subject: Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data Message-ID: <20150313151301.GJ5264@atomide.com> (sfid-20150313_161955_741917_8794A1BF) References: <1426162154-8716-1-git-send-email-eliad@wizery.com> <1426162154-8716-7-git-send-email-eliad@wizery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1426162154-8716-7-git-send-email-eliad@wizery.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: * Eliad Peller [150312 05:10]: > Now that we have wlcore device-tree bindings in place > (for both wl12xx and wl18xx), remove the legacy > wl12xx_platform_data struct, and move its members > into the platform device data (that is passed to wlcore) > > Davinci 850 is the only platform that still set > the platform data in the legacy way (and doesn't > have DT bindings), so remove the relevant > code/Kconfig option from the board file (as suggested > by Sekhar Nori) > > Signed-off-by: Luciano Coelho > Signed-off-by: Eliad Peller > --- > arch/arm/mach-davinci/Kconfig | 11 --- > arch/arm/mach-davinci/board-da850-evm.c | 113 ------------------------- > drivers/net/wireless/ti/wilink_platform_data.c | 25 ------ > drivers/net/wireless/ti/wl12xx/main.c | 19 ++--- > drivers/net/wireless/ti/wlcore/boot.c | 1 - > drivers/net/wireless/ti/wlcore/main.c | 4 +- > drivers/net/wireless/ti/wlcore/sdio.c | 75 +++++----------- > drivers/net/wireless/ti/wlcore/wlcore_i.h | 8 +- > include/linux/wl12xx.h | 25 ------ > 9 files changed, 36 insertions(+), 245 deletions(-) I got a build error related to the SPI driver with this series, probably need to update this patch: drivers/net/wireless/ti/wlcore/spi.c: In function ‘wl1271_probe’: drivers/net/wireless/ti/wlcore/spi.c:334:11: error: ‘struct wlcore_platdev_data’ has no member named ‘pdata’ pdev_data.pdata = dev_get_platdata(&spi->dev); ^ drivers/net/wireless/ti/wlcore/spi.c:335:16: error: ‘struct wlcore_platdev_data’ has no member named ‘pdata’ if (!pdev_data.pdata) { Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 13 Mar 2015 08:13:02 -0700 Subject: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data In-Reply-To: <1426162154-8716-7-git-send-email-eliad@wizery.com> References: <1426162154-8716-1-git-send-email-eliad@wizery.com> <1426162154-8716-7-git-send-email-eliad@wizery.com> Message-ID: <20150313151301.GJ5264@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Eliad Peller [150312 05:10]: > Now that we have wlcore device-tree bindings in place > (for both wl12xx and wl18xx), remove the legacy > wl12xx_platform_data struct, and move its members > into the platform device data (that is passed to wlcore) > > Davinci 850 is the only platform that still set > the platform data in the legacy way (and doesn't > have DT bindings), so remove the relevant > code/Kconfig option from the board file (as suggested > by Sekhar Nori) > > Signed-off-by: Luciano Coelho > Signed-off-by: Eliad Peller > --- > arch/arm/mach-davinci/Kconfig | 11 --- > arch/arm/mach-davinci/board-da850-evm.c | 113 ------------------------- > drivers/net/wireless/ti/wilink_platform_data.c | 25 ------ > drivers/net/wireless/ti/wl12xx/main.c | 19 ++--- > drivers/net/wireless/ti/wlcore/boot.c | 1 - > drivers/net/wireless/ti/wlcore/main.c | 4 +- > drivers/net/wireless/ti/wlcore/sdio.c | 75 +++++----------- > drivers/net/wireless/ti/wlcore/wlcore_i.h | 8 +- > include/linux/wl12xx.h | 25 ------ > 9 files changed, 36 insertions(+), 245 deletions(-) I got a build error related to the SPI driver with this series, probably need to update this patch: drivers/net/wireless/ti/wlcore/spi.c: In function ?wl1271_probe?: drivers/net/wireless/ti/wlcore/spi.c:334:11: error: ?struct wlcore_platdev_data? has no member named ?pdata? pdev_data.pdata = dev_get_platdata(&spi->dev); ^ drivers/net/wireless/ti/wlcore/spi.c:335:16: error: ?struct wlcore_platdev_data? has no member named ?pdata? if (!pdev_data.pdata) { Regards, Tony