From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Andi Kleen <andi@firstfloor.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Al Viro <viro@zeniv.linux.org.uk>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v3 0/2] x86_64: Sigcontext improvements
Date: Fri, 13 Mar 2015 16:31:55 +0100 [thread overview]
Message-ID: <20150313153155.GA23861@redhat.com> (raw)
In-Reply-To: <cover.1426193719.git.luto@kernel.org>
On 03/12, Andy Lutomirski wrote:
>
> Patch 1 is IMO a bug fix.
And personally I agree.
I am still not sure about renames in include/uapi, perhaps someone can
ack comment this change...
Perhaps we could could even do
- __u16 __pad0;
+ // comment to explain that ->ss is used starting from 4.x,
+ // __pad0 is still here to not break userspace.
+ union { __u16 __pad0; __u16 ss; }
But this is purely cosmetic, and I simply do not know if we should worry
about the potential compilation failure.
I believe both patches are good.
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
prev parent reply other threads:[~2015-03-13 15:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 20:57 [PATCH v3 0/2] x86_64: Sigcontext improvements Andy Lutomirski
2015-03-12 20:57 ` [PATCH v3 1/2] x86_64,signal: Fix SS handling for signals delivered to 64-bit programs Andy Lutomirski
2015-03-13 16:13 ` Borislav Petkov
2015-03-16 8:11 ` Ingo Molnar
2015-03-16 12:08 ` [tip:x86/asm] x86/signal/64: " tip-bot for Andy Lutomirski
2015-03-17 8:44 ` tip-bot for Andy Lutomirski
2015-03-18 17:19 ` [PATCH v3 1/2] x86_64,signal: " Andrey Wagin
2015-03-18 17:48 ` Oleg Nesterov
2015-03-18 18:06 ` Andy Lutomirski
2015-03-18 18:17 ` Cyrill Gorcunov
2015-03-18 18:20 ` Andy Lutomirski
2015-03-18 18:45 ` Cyrill Gorcunov
2015-03-18 18:25 ` Oleg Nesterov
2015-03-18 18:32 ` Andy Lutomirski
2015-03-18 19:13 ` Cyrill Gorcunov
2015-03-18 18:13 ` Cyrill Gorcunov
2015-03-18 18:31 ` Oleg Nesterov
2015-03-18 18:50 ` Cyrill Gorcunov
2015-03-18 19:52 ` Andrey Wagin
2015-03-18 20:02 ` Oleg Nesterov
2015-03-18 21:26 ` Andy Lutomirski
2015-03-18 21:34 ` Pavel Emelyanov
2015-03-18 22:03 ` Andy Lutomirski
2015-03-19 7:35 ` Cyrill Gorcunov
2015-03-19 16:08 ` Andy Lutomirski
2015-03-19 16:19 ` Cyrill Gorcunov
2015-03-20 11:43 ` Denys Vlasenko
2015-03-20 11:56 ` Cyrill Gorcunov
2015-03-20 12:04 ` Cyrill Gorcunov
2015-03-20 14:07 ` Oleg Nesterov
2015-03-20 14:47 ` Cyrill Gorcunov
2015-04-10 21:59 ` Andy Lutomirski
2015-04-10 22:11 ` Cyrill Gorcunov
2015-04-10 22:16 ` Andy Lutomirski
2015-04-10 22:20 ` Cyrill Gorcunov
2015-03-12 20:57 ` [PATCH v3 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext Andy Lutomirski
2015-03-16 12:08 ` [tip:x86/asm] x86/signal/64: " tip-bot for Andy Lutomirski
2015-03-17 8:44 ` tip-bot for Andy Lutomirski
2015-03-13 15:31 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313153155.GA23861@redhat.com \
--to=oleg@redhat.com \
--cc=andi@firstfloor.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.