Re: [Outreachy kernel] [PATCH 2/8] Staging: rtl8192e: Remove parentheses around right side an assignment

[Haneen <hamohammed.sa@gmail.com>]

On Fri, Mar 13, 2015 at 09:35:42PM +0100, Julia Lawall wrote:
> Your mail has a strange reply to address: 20150313165321.GA6657@haneen-vb
> 
I have noticed that and I am trying to resolve this issue

> > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> > index cd3c662..e208203 100644
> > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> > @@ -89,8 +89,8 @@ void rtl8192_setBBreg(struct net_device *dev, u32 dwRegAddr, u32 dwBitMask,
> >  	if (dwBitMask != bMaskDWord) {
> >  		OriginalValue = read_nic_dword(dev, dwRegAddr);
> >  		BitShift = rtl8192_CalculateBitShift(dwBitMask);
> > -		NewValue = (((OriginalValue) & (~dwBitMask)) |
> > -			    (dwData << BitShift));
> > +		NewValue = ((OriginalValue) & (~dwBitMask)) |
> > +			    (dwData << BitShift);
> 
> There are more unneeded parentheses here, on OriginalValue and ~dwBitMask.
> You can use Coccinelle to address this problem as well.
> 
> julia

Alright. Thanks!

Haneen