From: Uma Sharma <uma.sharma523@gmail.com>
To: xen-devel@lists.xen.org
Cc: andrew.cooper3@citrix.com, dario.faggioli@citrix.com,
keir@xen.org, George.Dunlap@citrix.com, jbeulich@suse.com
Subject: [PATCH 1/2] x86: identifying the boot cpu
Date: Fri, 13 Mar 2015 23:37:57 +0530 [thread overview]
Message-ID: <20150313180757.GA3155@gmail.com> (raw)
Provide helpers to access the socket and core IDs, resulting from
identification phase.
Initialize socket and core ID to -1 i.e invalid instead of 0. Having
that field in all elements set to 0 would induce credit2 to think that
the pCPU have already been initialized, and that all are on socket 0
in case of credit2 socket scheduler and on core 0 in case of credit2
core scheduler.
Signed-off-by: Uma Sharma <uma.sharma523@gmail.com>
---
xen/arch/x86/setup.c | 7 +++++--
xen/arch/x86/smpboot.c | 3 ++-
xen/include/asm-x86/processor.h | 2 ++
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 7593533..251840f 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1259,6 +1259,11 @@ void __init noreturn __start_xen(unsigned long mbi_p)
microcode_grab_module(module_map, mbi, bootstrap_map);
timer_init();
+ /*
+ * Identify the boot CPU, in case the scheduler initialization
+ * needs to know about it (e.g., topology, etc.)
+ */
+ identify_cpu(&boot_cpu_data);
init_idle_domain();
@@ -1270,8 +1275,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
arch_init_memory();
- identify_cpu(&boot_cpu_data);
-
if ( cpu_has_fxsr )
set_in_cr4(X86_CR4_OSFXSR);
if ( cpu_has_xmm )
diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index 314e253..ac8c4c8 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -59,7 +59,8 @@ DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_core_mask);
cpumask_t cpu_online_map __read_mostly;
EXPORT_SYMBOL(cpu_online_map);
-struct cpuinfo_x86 cpu_data[NR_CPUS];
+struct cpuinfo_x86 cpu_data[NR_CPUS] =
+ { [0 ... NR_CPUS-1] = { .phys_proc_id = -1, .cpu_core_id = -1 } };
u32 x86_cpu_to_apicid[NR_CPUS] __read_mostly =
{ [0 ... NR_CPUS-1] = BAD_APICID };
diff --git a/xen/include/asm-x86/processor.h b/xen/include/asm-x86/processor.h
index 87d80ff..6ec9588 100644
--- a/xen/include/asm-x86/processor.h
+++ b/xen/include/asm-x86/processor.h
@@ -214,7 +214,9 @@ extern void detect_extended_topology(struct cpuinfo_x86 *c);
extern void detect_ht(struct cpuinfo_x86 *c);
+#define boot_cpu_to_core() (boot_cpu_data.cpu_core_id)
#define cpu_to_core(_cpu) (cpu_data[_cpu].cpu_core_id)
+#define boot_cpu_to_socket() (boot_cpu_data.phys_proc_id)
#define cpu_to_socket(_cpu) (cpu_data[_cpu].phys_proc_id)
unsigned int apicid_to_socket(unsigned int);
--
1.9.1
next reply other threads:[~2015-03-13 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 18:07 Uma Sharma [this message]
2015-03-13 18:16 ` [PATCH 1/2] x86: identifying the boot cpu Andrew Cooper
2015-03-13 19:06 ` George Dunlap
2015-03-16 12:38 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313180757.GA3155@gmail.com \
--to=uma.sharma523@gmail.com \
--cc=George.Dunlap@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.