From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [PATCH] Lock 7 is cpuidle specific, use non-generic value for locking Date: Fri, 13 Mar 2015 15:02:04 -0500 Message-ID: <20150313200204.GB16977@qualcomm.com> References: <1425076217-10415-2-git-send-email-bjorn.andersson@sonymobile.com> <1426189108-35488-1-git-send-email-lina.iyer@linaro.org> <5501F889.1020800@codeaurora.org> <20150312204859.GD497@linaro.org> <55020142.80202@codeaurora.org> <20150312221600.GF497@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:33289 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbbCMUCG (ORCPT ); Fri, 13 Mar 2015 16:02:06 -0400 Content-Disposition: inline In-Reply-To: <20150312221600.GF497@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Lina Iyer Cc: Stephen Boyd , bjorn.andersson@sonymobile.com, linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 04:16:00PM -0600, Lina Iyer wrote: > >It looks like the remote side unlocks it too? It doesn't seem like this > >will work with the framework very well. The framework has a kernel > >spinlock attached to the hwspinlock so when we lock the hwspinlock we > >also lock the kernel spinlock and we only release the kernel spinlock > >when the kernel unlocks the hwspinlock. In this case it seems like > >cpuidle wants to have it's own kernel spinlock and just use the trylock > >loop part of __hwspin_lock_timeout() without taking any kernel side > >locks. Plus it wants to write a specific value to the lock. > > > Right. > Just noticed that part of the hwspinlock. Yes SCM unlocks the > hwspinlock. So I cannot hold any lock in Linux. May need changes in the > hwspinlock framework. Seems like an additional flag in hwspinlock to not > lock any in the trylock path work work. Hmm.... Or a specific EXPORT function for this one usecase which is unlike anyone elses usage. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project