All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: linux-parisc@vger.kernel.org,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	John David Anglin <dave.anglin@bell.net>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Bamvor Jian Zhang <bamvor.zhangjian@huawei.com>
Subject: [PATCH] parisc: compat Fix siginfo_t -> compat_siginfo_t conversion on big endian
Date: Sun, 15 Mar 2015 21:00:41 +0100	[thread overview]
Message-ID: <20150315200041.GA10927@ls3530.box> (raw)

This patch is basically the same as commit 9d42d48 from Catalin Marinas
but adopted to the parisc architecture.

The native (64-bit) sigval_t union contains sival_int (32-bit) and sival_ptr
(64-bit). When a compat application invokes a syscall that takes a sigval_t
value (as part of a larger structure, e.g.  compat_sys_mq_notify,
compat_sys_timer_create), the compat_sigval_t union is converted to the native
sigval_t with sival_int overlapping with either the least or the most
significant half of sival_ptr, depending on endianness. When the corresponding
signal is delivered to a compat application, on big endian the current
(compat_uptr_t)sival_ptr cast always returns 0 since sival_int corresponds to
the top part of sival_ptr. This patch fixes copy_siginfo_to_user32() so that
sival_int is copied to the compat_siginfo_t structure.

Cc: <stable@vger.kernel.org>
Reported-by: Bamvor Jian Zhang <bamvor.zhangjian@huawei.com>
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/kernel/signal32.c b/arch/parisc/kernel/signal32.c
index 984abbe..d1f1fcd 100644
--- a/arch/parisc/kernel/signal32.c
+++ b/arch/parisc/kernel/signal32.c
@@ -322,7 +322,6 @@ int
 copy_siginfo_to_user32 (compat_siginfo_t __user *to, const siginfo_t *from)
 {
 	compat_uptr_t addr;
-	compat_int_t val;
 	int err;
 
 	if (!access_ok(VERIFY_WRITE, to, sizeof(compat_siginfo_t)))
@@ -361,15 +360,13 @@ copy_siginfo_to_user32 (compat_siginfo_t __user *to, const siginfo_t *from)
 		case __SI_TIMER >> 16:
 			err |= __put_user(from->si_tid, &to->si_tid);
 			err |= __put_user(from->si_overrun, &to->si_overrun);
-			val = (compat_int_t)from->si_int;
-			err |= __put_user(val, &to->si_int);
+			err |= __put_user(from->si_int, &to->si_int);
 			break;
 		case __SI_RT >> 16:	/* Not generated by the kernel as of now.  */
 		case __SI_MESGQ >> 16:
 			err |= __put_user(from->si_uid, &to->si_uid);
 			err |= __put_user(from->si_pid, &to->si_pid);
-			val = (compat_int_t)from->si_int;
-			err |= __put_user(val, &to->si_int);
+			err |= __put_user(from->si_int, &to->si_int);
 			break;
 		}
 	}

             reply	other threads:[~2015-03-15 20:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-15 20:00 Helge Deller [this message]
2015-03-17 17:13 ` [PATCH] parisc: compat Fix siginfo_t -> compat_siginfo_t conversion on big endian Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150315200041.GA10927@ls3530.box \
    --to=deller@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bamvor.zhangjian@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=dave.anglin@bell.net \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.