From: Ingo Molnar <mingo@kernel.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Kees Cook <keescook@chromium.org>, Borislav Petkov <bp@suse.de>,
Baoquan He <bhe@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
Jiri Kosina <jkosina@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v4] x86, boot: Make data from decompress_kernel stage live longer
Date: Mon, 16 Mar 2015 08:45:43 +0100 [thread overview]
Message-ID: <20150316074543.GA15772@gmail.com> (raw)
In-Reply-To: <1426405744-21064-1-git-send-email-yinghai@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> After commit f47233c2d34f ("x86/mm/ASLR: Propagate base load address
> calculation"), get warning about setup_data from debugfs for
> setup_data. Boris found setup_data for kaslr from boot stage become
> all 0's in kernel stage.
And? What is the high level effect to the user?
'setup_data for kaslr from boot stage becomes all 0's' is not a high
level effect. It's a detail of the mechanism of the bug, not a high
level effect.
Think of a regular Linux user reading your changelogs. The first
paragraph of bug fixes should be readable to them!
_That_ is what 'high level' means.
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-16 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 7:49 [PATCH v4] x86, boot: Make data from decompress_kernel stage live longer Yinghai Lu
2015-03-16 7:45 ` Ingo Molnar [this message]
2015-03-16 19:25 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316074543.GA15772@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.