From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH v3 4/4] libxl: add support for vscsi Date: Mon, 16 Mar 2015 09:16:31 +0100 Message-ID: <20150316081631.GA11603@aepfle.de> References: <1425635156-2357-1-git-send-email-olaf@aepfle.de> <1425635156-2357-5-git-send-email-olaf@aepfle.de> <1426088006.21353.282.camel@citrix.com> <20150312160728.GA19536@aepfle.de> <1426178856.32572.57.camel@citrix.com> <20150313134528.GD25259@aepfle.de> <20150313151043.GA19822@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20150313151043.GA19822@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Stefano Stabellini , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, Mar 13, Wei Liu wrote: > On Fri, Mar 13, 2015 at 02:45:28PM +0100, Olaf Hering wrote: > > On Thu, Mar 12, Ian Campbell wrote: > > > > > On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote: > > > > Related: I see libxl_device_vscsi_dispose does now a pointer check, so I > > > > assume its required to validate input in libxl_device_vscsi_get_host. > > > Not sure what you mean, you should call libxl_device_vcsci_init before > > > using the object and then _dispose when you are done. > > > > I mean NULL pointer checks, will do that for at least *vscsi_host. > > > > That is only to make _dispose function NULL-tolerant. Why does that > affect your implementation? I have not checked other code pats in libxl, but does libxl expect valid input? At least glibc for example expects valid input, str*(NULL) crashes. Olaf