All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Raphaël Teysseyre" <rteysseyre@gmail.com>
Cc: Bryan Wu <cooloney@gmail.com>, Joe Xue <lgxue@hotmail.com>,
	"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds: Add arbitrary pattern trigger
Date: Mon, 16 Mar 2015 13:20:30 +0100	[thread overview]
Message-ID: <20150316122030.GA10642@amd> (raw)
In-Reply-To: <1426500410.11707.6.camel@localhost>

Hi!

I'd really return error if we can't parse user's input.

Small spelling fixes:

--- drivers/leds/trigger/ledtrig-pattern.c~	2015-03-16 12:07:06.897408622 +0100
+++ drivers/leds/trigger/ledtrig-pattern.c	2015-03-16 13:08:25.801864534 +0100
@@ -38,7 +38,7 @@
 	int nsteps;  /* Number of steps */
 	int repeat;  /* < 0 means repeat indefinitely */
 	struct timer_list timer; /* Used for scheduling updates to
-				    the led brightness */
+				    the LED brightness */
 };
 
 #define MAX_NSTEPS (PAGE_SIZE/4)
@@ -84,7 +84,7 @@
 
 /*
  *  is_sane : pattern checking.
- *  A pattern satisfaying these three conditions is reported as sane :
+ *  A pattern satisfying these three conditions is reported as sane :
  *    - At least two steps
  *    - At least one step with time >= UPDATE_INTERVAL
  *    - At least two steps with differing brightnesses


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2015-03-16 12:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19  8:26 [PATCH RFC] leds: Add status code trigger Raphaël Teysseyre
2015-03-09 21:15 ` Bryan Wu
2015-03-10  8:00   ` Pavel Machek
     [not found]     ` <BLU172-W3716E59BC9E98F60F424C4AC180@phx.gbl>
2015-03-10 19:22       ` Pavel Machek
2015-03-11 15:10         ` Raphaël Teysseyre
2015-03-11 19:02           ` Pavel Machek
2015-03-12  6:56             ` Raphaël Teysseyre
2015-03-16 10:06             ` [PATCH] leds: Add arbitrary pattern trigger Raphaël Teysseyre
2015-03-16 11:55               ` Pavel Machek
2015-03-16 16:49                 ` Raphaël Teysseyre
2015-03-16 12:20               ` Pavel Machek [this message]
2015-03-16 12:40               ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316122030.GA10642@amd \
    --to=pavel@ucw.cz \
    --cc=cooloney@gmail.com \
    --cc=lgxue@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=rteysseyre@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.