All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8712: replace memcpy with ether_addr_copy
Date: Mon, 16 Mar 2015 15:47:36 +0100	[thread overview]
Message-ID: <20150316144736.GB24906@kroah.com> (raw)
In-Reply-To: <1426339024-11656-1-git-send-email-hamohammed.sa@gmail.com>

On Sat, Mar 14, 2015 at 04:17:04PM +0300, Haneen Mohammed wrote:
> This patch replace memcpy with ethe_addr_copy to address the following
> warning generated by checkpatch.pl: ""Prefer ether_addr_copy over memcpy
> if the Ethernet addresses are __aligned(2)"
> 
> Follwoing is the output of pahole for the relevant datastructures:
> 1- for  "iwe.u.ap_addr.sa_data" and "wrqu->ap_addr.sa_data"
> 
> struct sockaddr {
>         sa_family_t                sa_family;            /*     0     2
> */
>         char                       sa_data[14];          /*     2    14
> */

Your lines are wrapped here very oddly.  Please fix that up and resend.

thanks,

greg k-h


  reply	other threads:[~2015-03-16 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-14 13:17 [PATCH] Staging: rtl8712: replace memcpy with ether_addr_copy Haneen Mohammed
2015-03-16 14:47 ` Greg KH [this message]
2015-03-16 15:41   ` [PATCH v2] " Haneen Mohammed
2015-03-17 15:35     ` [Outreachy kernel] " Jes Sorensen
  -- strict thread matches above, loose matches on Subject: below --
2015-03-14 11:15 [PATCH] Staging: rtl8712: Replace " Vatika Harlalka
2015-03-14 15:57 ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316144736.GB24906@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.