All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Hatice ERTÜRK" <haticeerturk27@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v4] Staging: rtl8192u: ieee80211: pr_warn instead printk
Date: Mon, 16 Mar 2015 15:50:10 +0100	[thread overview]
Message-ID: <20150316145010.GA31699@kroah.com> (raw)
In-Reply-To: <1425651496-14666-1-git-send-email-haticeerturk27@gmail.com>

On Fri, Mar 06, 2015 at 04:18:16PM +0200, Hatice ERT�RK wrote:
> This patch fixes the following warning using checkpatch.pl
> WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
> dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...
> 
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
> v4:
>  Changed patch number.
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> index ecd8542..8d4ade4 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> @@ -197,7 +197,7 @@ int ieee80211_encrypt_fragment(
>  			struct ieee80211_hdr_3addrqos *header;
>  
>  			header = (struct ieee80211_hdr_3addrqos *)frag->data;
> -			dev_debug(KERN_DEBUG "%s: TKIP countermeasures: dropped "
> +			dev_debug("%s: TKIP countermeasures: dropped "
>  			       "TX packet to %pM\n",
>  			       ieee->dev->name, header->addr1);

This doesn't even apply, let alone compile, what are you making it
against?


      parent reply	other threads:[~2015-03-16 14:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06 14:18 [PATCH v4] Staging: rtl8192u: ieee80211: pr_warn instead printk Hatice ERTÜRK
2015-03-06 15:40 ` [Outreachy kernel] " Julia Lawall
2015-03-16 14:50 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316145010.GA31699@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=haticeerturk27@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.