All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] kprobes/x86: Return correct length in __copy_instruction()
Date: Mon, 16 Mar 2015 16:03:45 +0100	[thread overview]
Message-ID: <20150316150345.GA18641@gmail.com> (raw)
In-Reply-To: <54FE5E14.8090303@hitachi.com>


* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

> (2015/03/09 20:19), Eugene Shatokhin wrote:
> > On x86-64, __copy_instruction() always returns 0 (error) if the
> > instruction uses %rip-relative addressing. This is because
> > kernel_insn_init() is called the second time for 'insn' instance
> > in such cases and sets all its fields to 0.
> > 
> > Because of this, trying to place a Kprobe on such instruction will
> > fail, register_kprobe() will return -EINVAL.
> 
> Oops, good catch!
> 
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Mind resending it with your SOB, as I wasn't Cc:-ed on the original 
submission?

Thanks,

	Ingo

  reply	other threads:[~2015-03-16 15:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 11:19 [PATCH] kprobes/x86: Return correct length in __copy_instruction() Eugene Shatokhin
2015-03-10  2:59 ` Masami Hiramatsu
2015-03-16 15:03   ` Ingo Molnar [this message]
2015-03-17  9:45     ` Masami Hiramatsu
2015-04-27 11:03       ` Eugene Shatokhin
2015-05-11 13:47         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316150345.GA18641@gmail.com \
    --to=mingo@kernel.org \
    --cc=eugene.shatokhin@rosalab.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.