All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Marek Belisko <marek.belisko@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: ft1000: remove unused variables
Date: Mon, 16 Mar 2015 16:33:02 +0100	[thread overview]
Message-ID: <20150316153302.GA12113@kroah.com> (raw)
In-Reply-To: <1425706013-8888-1-git-send-email-sudipm.mukherjee@gmail.com>

On Sat, Mar 07, 2015 at 10:56:52AM +0530, Sudip Mukherjee wrote:
> these variables were assigned some values but they were never being
> reused again.

But some of them should have been checked, right?  Or, if no one cares,
fix up the function to not return anything, like for all of the
read_register() calls.

Please do that instead.

thanks,

greg k-h

  parent reply	other threads:[~2015-03-16 15:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07  5:26 [PATCH 1/2] staging: ft1000: remove unused variables Sudip Mukherjee
2015-03-07  5:26 ` [PATCH 2/2] staging: ft1000: remove code indention Sudip Mukherjee
2015-03-16 15:33   ` Greg Kroah-Hartman
2015-03-17 11:13     ` Sudip Mukherjee
2015-03-16 15:33 ` Greg KH [this message]
2015-03-17 12:52   ` [PATCH 1/2] staging: ft1000: remove unused variables Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316153302.GA12113@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.belisko@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.