From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: pbonzini@redhat.com, berto@igalia.com, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/throttle: Use host clock type
Date: Mon, 16 Mar 2015 17:08:52 +0100 [thread overview]
Message-ID: <20150316160852.GG4707@noname.redhat.com> (raw)
In-Reply-To: <1426228529-15969-1-git-send-email-famz@redhat.com>
Am 13.03.2015 um 07:35 hat Fam Zheng geschrieben:
> Throttle timers won't make any progress when VCPU is not running, which
> is prone to stall the request queue in cases like utils, qtest,
> suspending, and live migration, unless carefully handled. What we do now
> is crude. For example in bdrv_drain_all, requests are resumed
> immediately without consulting throttling timer. Unfortunately
> bdrv_drain_all is so widely used that there may be too many holes that
> guest could bypass throttling.
>
> If we use the host clock, we can just trust the nested poll when waiting
> for requests.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
This breaks qemu-iotests 093. Dropped it again from the block branch.
Kevin
prev parent reply other threads:[~2015-03-16 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 6:35 [Qemu-devel] [PATCH] block/throttle: Use host clock type Fam Zheng
2015-03-13 8:08 ` Paolo Bonzini
2015-03-13 8:27 ` Fam Zheng
2015-03-13 11:09 ` Paolo Bonzini
2015-03-13 11:43 ` Fam Zheng
2015-03-13 12:23 ` Alberto Garcia
2015-03-13 12:28 ` Paolo Bonzini
2015-03-16 2:15 ` Fam Zheng
2015-03-16 15:18 ` Kevin Wolf
2015-03-16 16:08 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316160852.GG4707@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.