From: Vinod Koul <vinod.koul@intel.com>
To: Ameen Ali <ameenali023@gmail.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/11] iop-adma.c:1129: possible bad parameter in memset
Date: Mon, 16 Mar 2015 22:32:57 +0530 [thread overview]
Message-ID: <20150316170257.GW32683@intel.com> (raw)
In-Reply-To: <1426258514-6001-1-git-send-email-ameenali023@gmail.com>
On Fri, Mar 13, 2015 at 04:55:14PM +0200, Ameen Ali wrote:
> The 2nd memset() argument '286331153' doesn't fit into an 'unsigned char'.
care to explain hpow it is fixed...
>
> Signed-off-by : <AmeenAli023@gmail.com>
This is not proper, see Documentation/SubmittingPatches
> ---
> drivers/dma/iop-adma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c
> index 263d9f6..78382b0 100644
> --- a/drivers/dma/iop-adma.c
> +++ b/drivers/dma/iop-adma.c
> @@ -1126,7 +1126,7 @@ iop_adma_pq_zero_sum_self_test(struct iop_adma_device *device)
> /* Fill in src buffers */
> for (i = 0; i < IOP_ADMA_NUM_SRC_TEST; i++) {
> pq_sw[i] = page_address(pq[i]);
> - memset(pq_sw[i], 0x11111111 * (1<<i), PAGE_SIZE);
> + memset(pq_sw[i], 0x11111111 & (1<<i), PAGE_SIZE);
> }
> pq_sw[i] = page_address(pq[i]);
> pq_sw[i+1] = page_address(pq[i+1]);
> --
> 2.1.0
>
--
prev parent reply other threads:[~2015-03-16 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 14:55 [PATCH 11/11] iop-adma.c:1129: possible bad parameter in memset Ameen Ali
2015-03-16 17:02 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316170257.GW32683@intel.com \
--to=vinod.koul@intel.com \
--cc=ameenali023@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.