From: Greg KH <gregkh@linuxfoundation.org>
To: Vaishali Thakkar <vthakkar1994@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: speakup: Add helper macro for spk_synth boilerplate
Date: Mon, 16 Mar 2015 18:08:03 +0100 [thread overview]
Message-ID: <20150316170803.GC20171@kroah.com> (raw)
In-Reply-To: <CAK-LDbJKZpUrzc4rbaHM6mBQAs-NbnTTuwNjge_d0RN0yG=U9A@mail.gmail.com>
On Mon, Mar 16, 2015 at 10:34:34PM +0530, Vaishali Thakkar wrote:
> On Mon, Mar 16, 2015 at 10:19 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >> +#define module_spk_synth(__spk_synth) \
> >> + module_driver(__spk_synth, synth_add, \
> >> + synth_remove)
> >
> > Why the newline before synth_remove?
>
> Just for the consistency. I followed all such macro examples
> like module_usb_driver, module_platform_driver, module_pci_driver
> etc. And I guess may be this line will go over 80 characters though
> I haven't checked that.
>
> Should I go for writing like this in a single line
> [if it will not go beyond 80 characters]?
>
> module_driver(__spk_synth, synth_add, synth_remove) \
Yes, please do so, the only reason I wrapped the module_usb_driver()
lines was because I had to.
thanks,
greg k-h
next prev parent reply other threads:[~2015-03-16 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 14:29 [PATCH v2] Staging: speakup: Add helper macro for spk_synth boilerplate Vaishali Thakkar
2015-03-16 15:28 ` [Outreachy kernel] " Greg KH
2015-03-16 15:30 ` Vaishali Thakkar
2015-03-16 16:49 ` Julia Lawall
2015-03-16 17:04 ` Vaishali Thakkar
2015-03-16 17:08 ` Greg KH [this message]
2015-03-16 17:10 ` Vaishali Thakkar
2015-03-16 20:41 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316170803.GC20171@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.