All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@canonical.com>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>,
	linux-kernel@vger.kernel.org, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 1/1] pty, n_tty: continue processing input until the tty_buffer chain is flushed
Date: Mon, 16 Mar 2015 18:24:20 +0000	[thread overview]
Message-ID: <20150316182420.GC3753@dm> (raw)
In-Reply-To: <55071AEB.3030702@hurleysoftware.com>

On Mon, Mar 16, 2015 at 02:03:23PM -0400, Peter Hurley wrote:

> I just managed to reproduce this problem with a test jig;
> can you confirm that your self-tests also use >= 4096-byte read buffer
> (which I think is necessary to trigger the worker race)?

The read which triggers the EIO is indeed using a 4096 byte buffer:

    1396 read(17, 0x7f78214c3b30, 4096) = -1 EIO (Input/output error)

We found a simpler reproduce by than the upstart selftest which is included
in the bug linked in the commit text.  Specifically in comment 13 [1].

Thanks for looking at this.

-apw

[1] https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/1429756/comments/13

  reply	other threads:[~2015-03-16 18:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 14:30 [PATCH 1/1] pty, n_tty: continue processing input until the tty_buffer chain is flushed Andy Whitcroft
2015-03-16 18:03 ` Peter Hurley
2015-03-16 18:24   ` Andy Whitcroft [this message]
2015-03-24 15:56 ` Peter Hurley
2015-04-09 14:54   ` [PATCH] pty: Fix input race when closing Peter Hurley
2015-04-09 17:43     ` H.J. Lu
2015-04-09 17:53       ` Peter Hurley
2015-04-09 17:55         ` H.J. Lu
2015-04-09 22:11         ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316182420.GC3753@dm \
    --to=apw@canonical.com \
    --cc=alan@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.