From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [Patch v4 2/2] dmaengine: Add ADM driver Date: Tue, 17 Mar 2015 00:04:15 -0500 Message-ID: <20150317050415.GB28722@qualcomm.com> References: <1423719965-8156-1-git-send-email-agross@codeaurora.org> <1423719965-8156-3-git-send-email-agross@codeaurora.org> <20150313085745.GG32000@intel.com> <20150313220627.GB23640@qualcomm.com> <11135b79b94477532e57f30b1ea3c715.squirrel@www.codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:34024 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbbCQFER (ORCPT ); Tue, 17 Mar 2015 01:04:17 -0400 Content-Disposition: inline In-Reply-To: <11135b79b94477532e57f30b1ea3c715.squirrel@www.codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: sricharan@codeaurora.org Cc: Vinod Koul , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Kumar Gala , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Mon, Mar 16, 2015 at 08:15:26AM -0000, sricharan@codeaurora.org wrote: > Hi, > > > > > >> > >> > +static int adm_get_blksize(unsigned int burst) > >> > +{ > >> > + int ret; > >> > + > >> > + switch (burst) { > >> > + case 16: > >> > + ret = 0; > >> > + break; > >> > + case 32: > >> > + ret = 1; > >> > + break; > >> > + case 64: > >> > + ret = 2; > >> > + break; > >> > + case 128: > >> > + ret = 3; > >> > + break; > >> > + case 192: > >> > + ret = 4; > >> > + break; > >> > + case 256: > >> > + ret = 5; > >> > + break; > >> ffs(burst>>4) ? > > > > that should work nicely. thanks. > > > Will not work for 192, 256 ? you are right. I'll have to separate those out into 2 more cases. Good catch! -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: agross@codeaurora.org (Andy Gross) Date: Tue, 17 Mar 2015 00:04:15 -0500 Subject: [Patch v4 2/2] dmaengine: Add ADM driver In-Reply-To: <11135b79b94477532e57f30b1ea3c715.squirrel@www.codeaurora.org> References: <1423719965-8156-1-git-send-email-agross@codeaurora.org> <1423719965-8156-3-git-send-email-agross@codeaurora.org> <20150313085745.GG32000@intel.com> <20150313220627.GB23640@qualcomm.com> <11135b79b94477532e57f30b1ea3c715.squirrel@www.codeaurora.org> Message-ID: <20150317050415.GB28722@qualcomm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Mar 16, 2015 at 08:15:26AM -0000, sricharan at codeaurora.org wrote: > Hi, > > > > > >> > >> > +static int adm_get_blksize(unsigned int burst) > >> > +{ > >> > + int ret; > >> > + > >> > + switch (burst) { > >> > + case 16: > >> > + ret = 0; > >> > + break; > >> > + case 32: > >> > + ret = 1; > >> > + break; > >> > + case 64: > >> > + ret = 2; > >> > + break; > >> > + case 128: > >> > + ret = 3; > >> > + break; > >> > + case 192: > >> > + ret = 4; > >> > + break; > >> > + case 256: > >> > + ret = 5; > >> > + break; > >> ffs(burst>>4) ? > > > > that should work nicely. thanks. > > > Will not work for 192, 256 ? you are right. I'll have to separate those out into 2 more cases. Good catch! -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project