From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932957AbbCQLOE (ORCPT ); Tue, 17 Mar 2015 07:14:04 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:36471 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754124AbbCQLOB (ORCPT ); Tue, 17 Mar 2015 07:14:01 -0400 Date: Tue, 17 Mar 2015 16:43:49 +0530 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: Marek Belisko , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: ft1000: remove code indention Message-ID: <20150317111349.GA3823@sudip-PC> References: <1425706013-8888-1-git-send-email-sudipm.mukherjee@gmail.com> <1425706013-8888-2-git-send-email-sudipm.mukherjee@gmail.com> <20150316153334.GB12113@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150316153334.GB12113@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2015 at 04:33:34PM +0100, Greg Kroah-Hartman wrote: > On Sat, Mar 07, 2015 at 10:56:53AM +0530, Sudip Mukherjee wrote: > > modified the code to keep the logic same but removed some indention. > > > > Signed-off-by: Sudip Mukherjee > > --- > > > > this patch will generate checkpatch warning about line more than 80char, > > and too many use of tab. but unless the total function is rewrtten it will > > be difficult to fix that. > > > > drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 44 +++++++++++------------- > > 1 file changed, 21 insertions(+), 23 deletions(-) > > I don't see how this looks any better, do you? well, better in the sense very little indention was fixed and code which was repeating in if-else if - else was placed in a loop, but a small if-else was still there for the different delay between retries. I will see if i can make it more better. regards sudip